Issue 18502004: Propagate alignment for _Complex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18502004: Propagate alignment for _Complex (Closed)

Created:
7 years, 5 months ago by JF

Modified:
7 years, 5 months ago

Reviewers:
eliben

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-clang.git@master

Visibility:
Public.

More Reviews

Description

Propagate alignment for _Complex This issue fails the GCC torture tests after my atomic changes because complex-7.c uses volatile _Complex. I submitted a fix upstream today, but the code was changed to use LValue instead of Value so this patch is a temporary workaround until we merge to 3.3 and cherry-pick my fix on top. BUG= none TEST= ./tools/toolchain_tester/torture_test.py pnacl arm # or x86-32, or x86-64 TBR= eliben@chromium.org Committed: c148c41

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
	M	lib/CodeGen/CGExprComplex.cpp	View		3 chunks	+20 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

7 years, 5 months ago (2013-07-13 19:51:48 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as rc148c41 (presubmit successful).

Expand Messages | Collapse Messages