Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1850183003: Round out WillBe type removal. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, kouhei+heap_chromium.org, blink-reviews-css, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, kinuko+watch, Mads Ager (chromium), blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Round out WillBe type removal. A few leftovers. R=haraken BUG=585328 Committed: https://crrev.com/036a6d20b603d743947deb21aa939aa3f2c5b3fc Cr-Commit-Position: refs/heads/master@{#384804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -46 lines) Patch
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementData.cpp View 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 10 chunks +26 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-02 07:33:08 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-02 08:45:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850183003/1
4 years, 8 months ago (2016-04-02 08:56:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 10:40:18 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 10:41:12 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/036a6d20b603d743947deb21aa939aa3f2c5b3fc
Cr-Commit-Position: refs/heads/master@{#384804}

Powered by Google App Engine
This is Rietveld 408576698