Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 1850163004: S390: Implemented SLBR in s390 simulator. (Closed)

Created:
4 years, 8 months ago by bcleung
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Implemented SLBR in s390 simulator. This CL implements the SLBR, subtract logical 32-bit int with borrow, instruction in the s390 simulator. R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mbrandy@us.ibm.com,joransiu@ca.ibm.com, BUG= Committed: https://crrev.com/6dfcaafe501df2c888e072d11fa9f5655d1df52e Cr-Commit-Position: refs/heads/master@{#35211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/s390/simulator-s390.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
john.yan
lgtm
4 years, 8 months ago (2016-04-01 15:17:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850163004/1
4 years, 8 months ago (2016-04-01 15:28:39 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 15:51:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850163004/1
4 years, 8 months ago (2016-04-01 15:54:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 15:55:51 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 15:56:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dfcaafe501df2c888e072d11fa9f5655d1df52e
Cr-Commit-Position: refs/heads/master@{#35211}

Powered by Google App Engine
This is Rietveld 408576698