Subzero. Outputs liveness memory usage.

Subzero. Outputs liveness memory usage.

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a3984a124678df98b8fc9ae65ae733c5d07f14d1

[John, 2016-04-01 14:12:39]

jpp@chromium.org changed reviewers:
+ eholk@chromium.org, kschimpf@google.com, sehr@chromium.org,
stichnot@chromium.org

[Jim Stichnoth, 2016-04-01 15:22:34]

LGTM, thanks!

https://codereview.chromium.org/1850163003/diff/20001/src/IceCfg.h
File src/IceCfg.h (left):

https://codereview.chromium.org/1850163003/diff/20001/src/IceCfg.h#oldcode231
src/IceCfg.h:231: static size_t getTotalMemoryMB();
static - ah, oops!  :)

https://codereview.chromium.org/1850163003/diff/20001/src/IceCfg.h
File src/IceCfg.h (right):

https://codereview.chromium.org/1850163003/diff/20001/src/IceCfg.h#newcode230
src/IceCfg.h:230: /// mostly meant for use inside a debugger.
Remove the "debugger" comment.

https://codereview.chromium.org/1850163003/diff/20001/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/1850163003/diff/20001/src/IceGlobalContext.cp...
src/IceGlobalContext.cpp:263: static constexpr size_t _1MB = 1024 * 1024;
So this got me thinking, why were we seeing seeing negative numbers here with
that big example?  sizeof(size_t) and sizeof(ssize_t) should be 64-bit on the
native x86-64 platform.  Maybe some mis-typing in the underlying mallopt or
whatever library?

In any case, what do you think about casting the getMemUsed() result to size_t?

[John, 2016-04-01 18:05:51]

https://codereview.chromium.org/1850163003/diff/20001/src/IceCfg.h
File src/IceCfg.h (left):

https://codereview.chromium.org/1850163003/diff/20001/src/IceCfg.h#oldcode231
src/IceCfg.h:231: static size_t getTotalMemoryMB();
On 2016/04/01 15:22:34, stichnot wrote:
> static - ah, oops!  :)

Acknowledged.

https://codereview.chromium.org/1850163003/diff/20001/src/IceCfg.h
File src/IceCfg.h (right):

https://codereview.chromium.org/1850163003/diff/20001/src/IceCfg.h#newcode230
src/IceCfg.h:230: /// mostly meant for use inside a debugger.
On 2016/04/01 15:22:34, stichnot wrote:
> Remove the "debugger" comment.

Done.

https://codereview.chromium.org/1850163003/diff/20001/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/1850163003/diff/20001/src/IceGlobalContext.cp...
src/IceGlobalContext.cpp:263: static constexpr size_t _1MB = 1024 * 1024;
On 2016/04/01 15:22:34, stichnot wrote:
> So this got me thinking, why were we seeing seeing negative numbers here with
> that big example?  sizeof(size_t) and sizeof(ssize_t) should be 64-bit on the
> native x86-64 platform.  Maybe some mis-typing in the underlying mallopt or
> whatever library?
> 
> In any case, what do you think about casting the getMemUsed() result to
size_t?

Done.

[John, 2016-04-01 18:14:34]

Description was changed from

==========
Subzero. Outputs liveness memory usage.

BUG=
==========

to

==========
Subzero. Outputs liveness memory usage.

BUG=
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[John, 2016-04-01 18:14:36]

Committed patchset #3 (id:40001) manually as
a3984a124678df98b8fc9ae65ae733c5d07f14d1 (presubmit successful).