Roll cacheinvalidation DEPS to r330

Roll cacheinvalidation DEPS to r330

Changes are needed for GCM for Chrome on desktop.

Full list of changes:

322: Cleanup: Convert from scoped_ptr to std::unique_ptr.
323: remove unused mock methods
324: Add channel_common.proto
325: Revert r322 since Chrome does not yet support unique_ptr
326: update build datestamp
327: February 2014 invalidation client release
328: Adding copies of protos for use in C++ cache invalidation.
329: change protocol buffer compiler options in channel_common.proto
330: add lite runtime option to android_channel.proto

BUG=325020
R=meek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255300

[pavely, 2014-03-01 00:00:48]

Richard, could you take a look? You are in OWNERS of
third_party/cacheinvalidation

[rlarocque, 2014-03-01 00:05:58]

On 2014/03/01 00:00:48, pavely wrote:
> Richard, could you take a look? You are in OWNERS of
> third_party/cacheinvalidation

It looks like the trybots are failing for reasons related to this change.

[pavely, 2014-03-01 00:11:39]

On 2014/03/01 00:05:58, rlarocque wrote:
> On 2014/03/01 00:00:48, pavely wrote:
> > Richard, could you take a look? You are in OWNERS of
> > third_party/cacheinvalidation
> 
> It looks like the trybots are failing for reasons related to this change.

Ok, looks like I can't update revision in DEPS and update gyp file in the same
CL. Let me break this into two.

[pavely, 2014-03-01 00:15:16]

PTAL

[rlarocque, 2014-03-01 00:19:20]

On 2014/03/01 00:15:16, pavely wrote:
> PTAL

I'm not sure I agree with your diagnosis of the problem.  It should be safe to
update both at once.  Though it could be that there's some bug that prevents the
trybot from properly rebuilding everything.

Regardless, the change itself looks OK.  LGTM if the trybots accept it.

[pavely, 2014-03-05 00:48:46]

There were two issues with android build:
- proto file in examples did get passed through generator. I created separate
target for it.
- ANDROID constant in channel_commn conflicted with compiler define. I excluded
these protos from android build.

Please take a look.

[rlarocque, 2014-03-05 01:05:22]

LGTM with comments.

https://codereview.chromium.org/185013002/diff/60001/third_party/cacheinvalid...
File third_party/cacheinvalidation/cacheinvalidation.gyp (right):

https://codereview.chromium.org/185013002/diff/60001/third_party/cacheinvalid...
third_party/cacheinvalidation/cacheinvalidation.gyp:43: # channel_common.proto
contains definition of ANDRIOD constant which on
typo: ANDRIOD (and below)

https://codereview.chromium.org/185013002/diff/60001/third_party/cacheinvalid...
third_party/cacheinvalidation/cacheinvalidation.gyp:48: 'sources!': [
This is unfortunate.  Would it be possible to change one of the names so they
don't conflict?

[pavely, 2014-03-05 17:34:29]

https://codereview.chromium.org/185013002/diff/60001/third_party/cacheinvalid...
File third_party/cacheinvalidation/cacheinvalidation.gyp (right):

https://codereview.chromium.org/185013002/diff/60001/third_party/cacheinvalid...
third_party/cacheinvalidation/cacheinvalidation.gyp:43: # channel_common.proto
contains definition of ANDRIOD constant which on
On 2014/03/05 01:05:22, rlarocque wrote:
> typo: ANDRIOD (and below)

Done.

https://codereview.chromium.org/185013002/diff/60001/third_party/cacheinvalid...
third_party/cacheinvalidation/cacheinvalidation.gyp:48: 'sources!': [
On 2014/03/05 01:05:22, rlarocque wrote:
> This is unfortunate.  Would it be possible to change one of the names so they
> don't conflict?
I was talking to Colin about this yesterday. channel_common.proto is actually a
copy from java library with the same constant defined. They are not changing
java version and letting files diverge seemed worse than excluding file from
android build. Their primary focus for development is java client library
therefore I don't see us switching to native cacheinvalidations library for
android. This solution seems acceptable.

[pavely, 2014-03-05 17:34:55]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2014-03-05 17:35:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/185013002/80001

[commit-bot: I haz the power, 2014-03-05 20:02:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 20:02:10]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pavely, 2014-03-05 20:04:46]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2014-03-05 20:05:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/185013002/80001

[commit-bot: I haz the power, 2014-03-05 20:17:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 20:17:05]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pavely, 2014-03-05 22:11:23]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2014-03-05 22:11:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/185013002/100001

[commit-bot: I haz the power, 2014-03-05 23:13:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 23:13:45]

Try jobs failed on following builders: mac_chromium_rel

[pavely, 2014-03-05 23:22:43]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2014-03-05 23:28:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/185013002/100001

[commit-bot: I haz the power, 2014-03-06 00:10:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/185013002/100001

[commit-bot: I haz the power, 2014-03-06 02:51:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/185013002/100001

[commit-bot: I haz the power, 2014-03-06 03:16:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavely@chromium.org/185013002/100001

[commit-bot: I haz the power, 2014-03-06 10:40:38]

Change committed as 255300