Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2327)

Unified Diff: chrome/browser/importer/importer_uma.cc

Issue 18501013: Move most importer code to chrome/utility/importer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: another gyp attempt Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/importer/importer_uma.h ('k') | chrome/browser/importer/in_process_importer_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/importer/importer_uma.cc
diff --git a/chrome/browser/importer/importer_creator.cc b/chrome/browser/importer/importer_uma.cc
similarity index 66%
rename from chrome/browser/importer/importer_creator.cc
rename to chrome/browser/importer/importer_uma.cc
index 7127ed2c59055054397f5a5864898ab792dc5f9d..4e62217c7caa71e987003016d1de20bf85c6b9f9 100644
--- a/chrome/browser/importer/importer_creator.cc
+++ b/chrome/browser/importer/importer_uma.cc
@@ -2,22 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/importer/importer_creator.h"
-
-#include "base/logging.h"
-#include "base/metrics/histogram.h"
-#include "chrome/browser/importer/bookmarks_file_importer.h"
-#include "chrome/browser/importer/firefox3_importer.h"
-
-#if defined(OS_WIN)
-#include "chrome/browser/importer/ie_importer.h"
-#endif
-
-#if defined(OS_MACOSX)
-#include <CoreFoundation/CoreFoundation.h>
-#include "base/mac/foundation_util.h"
-#include "chrome/browser/importer/safari_importer.h"
-#endif
+#include "build/build_config.h"
+#include "chrome/browser/importer/importer_uma.h"
namespace importer {
@@ -42,31 +28,8 @@ enum ImporterTypeMetrics {
IMPORTER_METRICS_SIZE
};
-
} // namespace
-Importer* CreateImporterByType(ImporterType type) {
- switch (type) {
-#if defined(OS_WIN)
- case TYPE_IE:
- return new IEImporter();
-#endif
- case TYPE_BOOKMARKS_FILE:
- return new BookmarksFileImporter();
- case TYPE_FIREFOX3:
- return new Firefox3Importer();
-#if defined(OS_MACOSX)
- case TYPE_SAFARI:
- return new SafariImporter(base::mac::GetUserLibraryPath());
-#endif
- default:
- NOTREACHED();
- return NULL;
- }
- NOTREACHED();
- return NULL;
-}
-
void LogImporterUseToMetrics(const std::string& metric_postfix,
ImporterType type) {
ImporterTypeMetrics metrics_type = IMPORTER_METRICS_UNKNOWN;
« no previous file with comments | « chrome/browser/importer/importer_uma.h ('k') | chrome/browser/importer/in_process_importer_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698