chrome/utility/DEPS - Issue 18501013: Move most importer code to chrome/utility/importer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/utility/DEPS

Issue 18501013: Move most importer code to chrome/utility/importer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CanImport Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/importer/importer_visit_source.h ('K') | « chrome/common/importer/pstore_declarations.h ('k') | chrome/utility/importer/OWNERS » ('j') | chrome/utility/importer/bookmark_html_reader.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # For out of process profile import. This code needs to be factored out to	2 # For out of process profile import. This code needs to be factored out to
	gab 2013/07/10 13:40:44 This comment can be removed as it was directed at This comment can be removed as it was directed at the remove rule for "+chrome/browser/importer" scottmg 2013/07/15 16:06:01 Done. Show quoted text On 2013/07/10 13:40:44, gab wrote: > This comment can be removed as it was directed at the remove rule for > "+chrome/browser/importer" Done.
3 # chrome/common.	3 # chrome/common.

4 "+chrome/browser/importer",

5 "+chrome/common/local_discovery",	4 "+chrome/common/local_discovery",
	gab 2013/07/10 13:40:44 Add "+chrome/common/importer" too? Add "+chrome/common/importer" too? gab 2013/07/10 13:53:21 Actually chrome/DEPS seems to always allow anythin Show quoted text On 2013/07/10 13:40:44, gab wrote: > Add "+chrome/common/importer" too? Actually chrome/DEPS seems to always allow anything in chrome/ to include from chrome/common so neither "+chrome/common/importer", nor the current "+chrome/common/local_discovery" are needed here I'd say. scottmg 2013/07/15 16:06:01 Done. Show quoted text On 2013/07/10 13:53:21, gab wrote: > On 2013/07/10 13:40:44, gab wrote: > > Add "+chrome/common/importer" too? > > Actually chrome/DEPS seems to always allow anything in chrome/ to include from > chrome/common so neither "+chrome/common/importer", nor the current > "+chrome/common/local_discovery" are needed here I'd say. Done.
6 "+content/public/child",	5 "+content/public/child",

7 "+content/public/utility",	6 "+content/public/utility",

8 "+webkit/glue",	7 "+webkit/glue",

	8

	9 # For generated headers.

	10 "+grit",

	11

	12 "+skia/ext",

	13

	14 # Should not be using browser code.

	15 "-chrome/browser",

9 ]	16 ]

OLD	NEW