Move most importer code to chrome/utility/importer

chrome/common/importer/importer_bridge.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_IMPORTER_IMPORTER_BRIDGE_H_
-#define CHROME_BROWSER_IMPORTER_IMPORTER_BRIDGE_H_
+#ifndef CHROME_COMMON_IMPORTER_IMPORTER_BRIDGE_H_
+#define CHROME_COMMON_IMPORTER_IMPORTER_BRIDGE_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string16.h"
 #include "build/build_config.h"
-#include "chrome/browser/history/history_types.h"
 #include "chrome/common/importer/importer_data_types.h"
 #include "chrome/common/importer/importer_url_row.h"
+#include "chrome/common/importer/importer_visit_source.h"

[gab, 2013/07/10 13:40:44]

nit: Remove this include along with the file.

[scottmg, 2013/07/15 16:06:01]

Done.

 
 class GURL;
 struct ImportedBookmarkEntry;
 struct ImportedFaviconUsage;
 
 namespace importer {
 #if defined(OS_WIN)
 struct ImporterIE7PasswordInfo;
 #endif
 struct ImporterURlRow;
 struct URLKeywordInfo;
 }
 
 namespace content {
 struct PasswordForm;
 }
 
 class ImporterBridge : public base::RefCountedThreadSafe<ImporterBridge> {

[gab, 2013/07/10 13:40:44]

I think this should be a pure-virtual interface instead of having it's own .cc
file for no real purpose.

i.e., Remove constructor and make protected destructor pure-virtual?

I don't think this needs to go in this CL, but I think it would be nice to
minimize .cc files in chrome/browser/common

  public:
   ImporterBridge();
 
   virtual void AddBookmarks(
       const std::vector<ImportedBookmarkEntry>& bookmarks,
       const string16& first_folder_name) = 0;
 
   virtual void AddHomePage(const GURL& home_page) = 0;
 
 #if defined(OS_WIN)
@@ skipping 39 matching lines @@
   virtual string16 GetLocalizedString(int message_id) = 0;
 
  protected:
   friend class base::RefCountedThreadSafe<ImporterBridge>;
 
   virtual ~ImporterBridge();
 
   DISALLOW_COPY_AND_ASSIGN(ImporterBridge);
 };
 
-#endif  // CHROME_BROWSER_IMPORTER_IMPORTER_BRIDGE_H_
+#endif  // CHROME_COMMON_IMPORTER_IMPORTER_BRIDGE_H_