chrome/browser/bookmarks/DEPS - Issue 18501013: Move most importer code to chrome/utility/importer

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 18501013: Move most importer code to chrome/utility/importer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CanImport Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/DEPS ('K') | « chrome/browser/DEPS ('k') | chrome/browser/bookmarks/bookmark_html_writer_unittest.cc » ('j') | chrome/browser/importer/firefox_proxy_settings.cc » ('J')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Bookmarks is being made into a component (it will end up at	2 # Bookmarks is being made into a component (it will end up at

3 # //components/bookmarks and not depend on //chrome), so we have these basic	3 # //components/bookmarks and not depend on //chrome), so we have these basic

4 # rules followed by temporary exceptions. Please don't add to the list of	4 # rules followed by temporary exceptions. Please don't add to the list of

5 # exceptions!	5 # exceptions!

6 "-chrome/browser",	6 "-chrome/browser",

7 "+chrome/browser/bookmarks",	7 "+chrome/browser/bookmarks",

8 "+chrome/browser/favicon",	8 "+chrome/browser/favicon",

9	9

	10 # For unit tests.

	11 "+chrome/utility/importer/bookmark_html_reader.h",
	gab 2013/07/10 13:40:44 I still don't like this as it allows anyone in boo I still don't like this as it allows anyone in bookmarks/ to include the reader which is wrong. Perhaps make this a '!' rule (this is a warning if my previous assumptions are correct?)? Otherwise we could add a c/b/bookmarks/test directory, but that might be overkill for a single test..? tfarina 2013/07/10 13:46:55 you can use specific_include_rules for this. see a Show quoted text On 2013/07/10 13:40:44, gab wrote: > I still don't like this as it allows anyone in bookmarks/ to include the reader > which is wrong. > > Perhaps make this a '!' rule (this is a warning if my previous assumptions are > correct?)? > > Otherwise we could add a c/b/bookmarks/test directory, but that might be > overkill for a single test..? you can use specific_include_rules for this. see a good example of how to do this for a single unittest that needs this include like here: components/autofill/content/browser/DEPS scottmg 2013/07/15 16:06:01 Thanks Thiago, changed to a specific_include_rules Show quoted text On 2013/07/10 13:46:55, tfarina wrote: > On 2013/07/10 13:40:44, gab wrote: > > I still don't like this as it allows anyone in bookmarks/ to include the > reader > > which is wrong. > > > > Perhaps make this a '!' rule (this is a warning if my previous assumptions are > > correct?)? > > > > Otherwise we could add a c/b/bookmarks/test directory, but that might be > > overkill for a single test..? > you can use specific_include_rules for this. > see a good example of how to do this for a single unittest that needs this > include like here: components/autofill/content/browser/DEPS Thanks Thiago, changed to a specific_include_rules.
	12

10 # TODO(kaiwang): Bring this list to zero.	13 # TODO(kaiwang): Bring this list to zero.

11 # Do not add to the list of temporarily-allowed dependencies below,	14 # Do not add to the list of temporarily-allowed dependencies below,

12 # and please do not introduce more #includes of these files.	15 # and please do not introduce more #includes of these files.

13 "!chrome/browser/history/history_service.h",	16 "!chrome/browser/history/history_service.h",

14 "!chrome/browser/history/history_service_factory.h",	17 "!chrome/browser/history/history_service_factory.h",

15 "!chrome/browser/history/query_parser.h",	18 "!chrome/browser/history/query_parser.h",

16 "!chrome/browser/history/url_database.h",	19 "!chrome/browser/history/url_database.h",

17 "!chrome/browser/profiles/incognito_helpers.h",	20 "!chrome/browser/profiles/incognito_helpers.h",

18 "!chrome/browser/profiles/profile.h",	21 "!chrome/browser/profiles/profile.h",

19 "!chrome/browser/profiles/startup_task_runner_service.h",	22 "!chrome/browser/profiles/startup_task_runner_service.h",

20 "!chrome/browser/profiles/startup_task_runner_service_factory.h",	23 "!chrome/browser/profiles/startup_task_runner_service_factory.h",

21 # Do not add to the list of temporarily-allowed dependencies above,	24 # Do not add to the list of temporarily-allowed dependencies above,

22 # and please do not introduce more #includes of these files.	25 # and please do not introduce more #includes of these files.

23 ]	26 ]

OLD	NEW