chrome/browser/DEPS - Issue 18501013: Move most importer code to chrome/utility/importer

Side by Side Diff: chrome/browser/DEPS

Issue 18501013: Move most importer code to chrome/utility/importer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CanImport Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+apps",	2 "+apps",

3 "+breakpad",	3 "+breakpad",

4 "+chrome/app",	4 "+chrome/app",

5 "+chrome/installer",	5 "+chrome/installer",

6 "+chrome/tools/profiles", # For history unit tests.	6 "+chrome/tools/profiles", # For history unit tests.

7 "+chromeos",	7 "+chromeos",

8 "+components/autofill/content/browser",	8 "+components/autofill/content/browser",

9 "+components/autofill/core/browser",	9 "+components/autofill/core/browser",

10 "+components/autofill/core/common",	10 "+components/autofill/core/common",

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 "!content/public/child/image_decoder_utils.h",	64 "!content/public/child/image_decoder_utils.h",

65	65

66 # webkit/glue files are listed individually since they aren't conceptually	66 # webkit/glue files are listed individually since they aren't conceptually

67 # grouped like the other webkit/ files, and can therefore be tackled one at	67 # grouped like the other webkit/ files, and can therefore be tackled one at

68 # a time.	68 # a time.

69 "+webkit/glue/resource_type.h",	69 "+webkit/glue/resource_type.h",

70 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST!	70 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST!

71	71

72 "-chrome/browser/ui/views",	72 "-chrome/browser/ui/views",

73	73

	74 # Should not be using utility process code. http://crbug.com/254672

	75 "!chrome/utility",
	gab 2013/07/10 13:40:44 Just checking, I've never seen '!' DEPS rules, I a Just checking, I've never seen '!' DEPS rules, I assume those result in warning rather than errors? Perhaps add a TODO here stating what remains to be done before this is turned into a '-'? I don't feel strongly about this since I know you'll clean it up soon after, up to you. tfarina 2013/07/10 13:44:36 it means this rule is temporary and will generate Show quoted text On 2013/07/10 13:40:44, gab wrote: > Just checking, I've never seen '!' DEPS rules, I assume those result in warning > rather than errors? > it means this rule is temporary and will generate a presubmit warning when someone tries to add chrome/utility in a file under chrome/browser. Show quoted text > Perhaps add a TODO here stating what remains to be done before this is turned > into a '-'? I don't feel strongly about this since I know you'll clean it up > soon after, up to you.
	76

74 # Other libraries.	77 # Other libraries.

75 "+chrome/third_party/mozilla_security_manager",	78 "+chrome/third_party/mozilla_security_manager",

76 "+libxml", # For search engine definition parsing.	79 "+libxml", # For search engine definition parsing.

77 "+third_party/apple_sample_code", # Apple code ImageAndTextCell.	80 "+third_party/apple_sample_code", # Apple code ImageAndTextCell.

78 "+third_party/bzip2",	81 "+third_party/bzip2",

79 "+third_party/cld",	82 "+third_party/cld",

80 "+third_party/expat",	83 "+third_party/expat",

81 "+third_party/iaccessible2",	84 "+third_party/iaccessible2",

82 "+third_party/icu",	85 "+third_party/icu",

83 "+third_party/isimpledom",	86 "+third_party/isimpledom",

(...skipping 27 matching lines...) Expand all Loading...
111 "+third_party/WebKit/public/web/WebPluginAction.h",	114 "+third_party/WebKit/public/web/WebPluginAction.h",

112 "+third_party/WebKit/public/web/WebScreenInfo.h",	115 "+third_party/WebKit/public/web/WebScreenInfo.h",

113 "+third_party/WebKit/public/web/WebTextDirection.h",	116 "+third_party/WebKit/public/web/WebTextDirection.h",

114	117

115 # These should be burned down. http://crbug.com/237267	118 # These should be burned down. http://crbug.com/237267

116 "!third_party/WebKit/public/web/WebKit.h",	119 "!third_party/WebKit/public/web/WebKit.h",

117 "!third_party/WebKit/public/web/WebSecurityOrigin.h",	120 "!third_party/WebKit/public/web/WebSecurityOrigin.h",

118 "!third_party/WebKit/public/web/WebSecurityPolicy.h",	121 "!third_party/WebKit/public/web/WebSecurityPolicy.h",

119 "!third_party/WebKit/public/web/WebView.h",	122 "!third_party/WebKit/public/web/WebView.h",

120 ]	123 ]

OLD	NEW

« no previous file with comments | « android_webview/tools/third_party_files_whitelist.txt ('k') | chrome/browser/bookmarks/DEPS » ('j') | chrome/browser/bookmarks/DEPS » ('J')