chrome/utility/importer/OWNERS - Issue 18501013: Move most importer code to chrome/utility/importer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/utility/importer/OWNERS

Issue 18501013: Move most importer code to chrome/utility/importer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix include on mac Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 gab@chromium.org	1 gab@chromium.org

2 isherman@chromium.org	2 isherman@chromium.org

3 mirandac@chromium.org	3 mirandac@chromium.org

4	4

5 # For security review of IPC message files.	5 # For security review of IPC message files.
	gab 2013/07/09 20:48:31 Does this section apply to c/u/i? The only messag Does this section apply to c/u/i? The only messages file seems to be for a unit test. scottmg 2013/07/09 21:16:45 Yeah, it's just for the FF unittests. Seems less l Show quoted text On 2013/07/09 20:48:31, gab wrote: > Does this section apply to c/u/i? > > The only messages file seems to be for a unit test. Yeah, it's just for the FF unittests. Seems less likely to incur the wrath of the security team in case there's more messages added in the future. (It'd be nice to have that globally instead of in all the folders)
6 per-file _messages.h=set noparent	6 per-file _messages.h=set noparent

7 per-file _messages.h=cdn@chromium.org	7 per-file _messages.h=cdn@chromium.org

8 per-file _messages.h=cevans@chromium.org	8 per-file _messages.h=cevans@chromium.org

9 per-file _messages.h=inferno@chromium.org	9 per-file _messages.h=inferno@chromium.org

10 per-file _messages.h=jschuh@chromium.org	10 per-file _messages.h=jschuh@chromium.org

11 per-file _messages.h=palmer@chromium.org	11 per-file _messages.h=palmer@chromium.org

12 per-file _messages.h=tsepez@chromium.org	12 per-file _messages.h=tsepez@chromium.org

OLD	NEW

OLD	NEW
1 gab@chromium.org	1 gab@chromium.org

2 isherman@chromium.org	2 isherman@chromium.org

3 mirandac@chromium.org	3 mirandac@chromium.org

4	4

5 # For security review of IPC message files.	5 # For security review of IPC message files.
	gab 2013/07/09 20:48:31 Does this section apply to c/u/i? The only messag Does this section apply to c/u/i? The only messages file seems to be for a unit test. scottmg 2013/07/09 21:16:45 Yeah, it's just for the FF unittests. Seems less l Show quoted text On 2013/07/09 20:48:31, gab wrote: > Does this section apply to c/u/i? > > The only messages file seems to be for a unit test. Yeah, it's just for the FF unittests. Seems less likely to incur the wrath of the security team in case there's more messages added in the future. (It'd be nice to have that globally instead of in all the folders)
6 per-file _messages.h=set noparent	6 per-file _messages.h=set noparent

7 per-file _messages.h=cdn@chromium.org	7 per-file _messages.h=cdn@chromium.org

8 per-file _messages.h=cevans@chromium.org	8 per-file _messages.h=cevans@chromium.org

9 per-file _messages.h=inferno@chromium.org	9 per-file _messages.h=inferno@chromium.org

10 per-file _messages.h=jschuh@chromium.org	10 per-file _messages.h=jschuh@chromium.org

11 per-file _messages.h=palmer@chromium.org	11 per-file _messages.h=palmer@chromium.org

12 per-file _messages.h=tsepez@chromium.org	12 per-file _messages.h=tsepez@chromium.org

OLD	NEW