Move most importer code to chrome/utility/importer

chrome/common/importer/firefox_importer_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

[gab, 2013/07/09 20:48:31]

Do all of these method need to be common?

I feel most of them are probably only used by one side or the other, no?

[scottmg, 2013/07/09 21:16:45]

Possibly. The implementation of the functions was using the generic ones
(GetPrefsJsValue) so some has to be in common.

How about I try to tease them apart while doing the same thing for the
safari_importer_utils?

[gab, 2013/07/09 21:29:43]

sgtm.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_IMPORTER_FIREFOX_IMPORTER_UTILS_H_
-#define CHROME_BROWSER_IMPORTER_FIREFOX_IMPORTER_UTILS_H_
+#ifndef CHROME_COMMON_IMPORTER_FIREFOX_IMPORTER_UTILS_H_
+#define CHROME_COMMON_IMPORTER_FIREFOX_IMPORTER_UTILS_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/strings/string16.h"
 #include "build/build_config.h"
 
 class GURL;
 class TemplateURL;
@@ skipping 61 matching lines @@
 // the resource file browserconfig.properties in the Firefox application
 // directory.
 bool IsDefaultHomepage(const GURL& homepage, const base::FilePath& app_path);
 
 // Parses the prefs found in the file |pref_file| and puts the key/value pairs
 // in |prefs|. Keys are strings, and values can be strings, booleans or
 // integers.  Returns true if it succeeded, false otherwise (in which case
 // |prefs| is not filled).
 // Note: for strings, only valid UTF-8 string values are supported. If a
 // key/pair is not valid UTF-8, it is ignored and will not appear in |prefs|.
-bool ParsePrefFile(const base::FilePath& pref_file, base::DictionaryValue* prefs);
+bool ParsePrefFile(const base::FilePath& pref_file,
+                   base::DictionaryValue* prefs);
 
 // Parses the value of a particular firefox preference from a string that is the
 // contents of the prefs file.
 std::string GetPrefsJsValue(const std::string& prefs,
                             const std::string& pref_key);
 
 // Returns the localized Firefox branding name.
 // This is useful to differentiate between Firefox and Iceweasel.
 // If anything goes wrong while trying to obtain the branding name,
 // the function assumes it's Firefox.
 string16 GetFirefoxImporterName(const base::FilePath& app_path);
 
-#endif  // CHROME_BROWSER_IMPORTER_FIREFOX_IMPORTER_UTILS_H_
+#endif  // CHROME_COMMON_IMPORTER_FIREFOX_IMPORTER_UTILS_H_