Move most importer code to chrome/utility/importer

chrome/browser/importer/in_process_importer_bridge.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/importer/in_process_importer_bridge.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/importer/external_process_importer_host.h"
@@ skipping 36 matching lines @@
     importer::VisitSource visit_source) {
   switch (visit_source) {
     case importer::VISIT_SOURCE_BROWSED:
       return history::SOURCE_BROWSED;
     case importer::VISIT_SOURCE_FIREFOX_IMPORTED:
       return history::SOURCE_FIREFOX_IMPORTED;
     case importer::VISIT_SOURCE_IE_IMPORTED:
       return history::SOURCE_IE_IMPORTED;
     case importer::VISIT_SOURCE_SAFARI_IMPORTED:
       return history::SOURCE_SAFARI_IMPORTED;
-  }
+  };
   NOTREACHED();

[gab, 2013/07/09 20:48:31]

I think these last 2 lines can be removed.

[scottmg, 2013/07/09 21:16:45]

I think they should be kept in case new enums are added. I can put them in a
default: if you prefer.

The ; can definitely be nuked!

[gab, 2013/07/09 21:29:43]

Well if they are removed and new enums are added, this won't compile, if we
leave them there, then it will compile, but not behave properly...

I prefer the former :).

[scottmg, 2013/07/09 23:03:09]

I don't believe that's true. e.g. win vs2010 release:

d:\src\cr3\src\chrome\browser\importer\in_process_importer_bridge.cc(58) :
warning C4715: '`anonymous
namespace'::ConvertImporterVisitSourceToHistoryVisitSource' : not all control
paths return a value

I can see a reasonable argument either way for having it inside or outside of
the switch though.

   return history::SOURCE_SYNCED;
 }
 
 }  // namespace
 
 using content::BrowserThread;
 
 namespace {
 
 // FirefoxURLParameterFilter is used to remove parameter mentioning Firefox from
@@ skipping 207 matching lines @@
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&ExternalProcessImporterHost::NotifyImportEnded, host_));
 }
 
 string16 InProcessImporterBridge::GetLocalizedString(int message_id) {
   return l10n_util::GetStringUTF16(message_id);
 }
 
 InProcessImporterBridge::~InProcessImporterBridge() {}