Move most importer code to chrome/utility/importer

chrome/browser/bookmarks/DEPS

 include_rules = [
   # Bookmarks is being made into a component (it will end up at
   # //components/bookmarks and not depend on //chrome), so we have these basic
   # rules followed by temporary exceptions.  Please don't add to the list of
   # exceptions!
   "-chrome/browser",
   "+chrome/browser/bookmarks",
   "+chrome/browser/favicon",
   "+chrome/browser/chrome_notification_types.h",
 
   # TODO(kaiwang): Bring this list to zero.
   # Do not add to the list of temporarily-allowed dependencies below,
   # and please do not introduce more #includes of these files.
   "!chrome/browser/history/history_service.h",
   "!chrome/browser/history/history_service_factory.h",
   "!chrome/browser/history/query_parser.h",
   "!chrome/browser/history/url_database.h",
   "!chrome/browser/profiles/incognito_helpers.h",
   "!chrome/browser/profiles/profile.h",
   "!chrome/browser/profiles/startup_task_runner_service.h",
   "!chrome/browser/profiles/startup_task_runner_service_factory.h",
   # Do not add to the list of temporarily-allowed dependencies above,
   # and please do not introduce more #includes of these files.
 ]
+
+specific_include_rules = {
+  # For unit tests, it's fine to include utility process code.
+  '.*test\.cc': [
+    "+chrome/utility/importer/bookmark_html_reader.h",

[jam, 2013/07/15 19:54:14]

we shouldn't have this, even for test. unit tests which use code that runs the
utility process now can run that in-process, i.e.
https://codereview.chromium.org/19085002/diff/1/chrome/browser/extensions/upd...

[scottmg, 2013/07/15 20:20:43]

Sorry, I don't think I understand.

bookmark_html_writer_unittest (i.e. only the test code) uses
bookmark_html_reader to verify that the bookmarks.html file that it writes is
valid.

bookmark_html_reader uses WebKit to decode favicons, so we don't want a
dependency on that from the browser.

Can you suggest a better approach?

[jam, 2013/07/15 20:25:54]

hmm, i can't, so ok. perhaps we should have a subdir under chrome/test for these
kind of tests, but that's outside the scope of this change

+  ],
+}