Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1850053002: add if defined(_MSC_FULL_VER) for NaCL (Closed)

Created:
4 years, 8 months ago by fbarchard1
Modified:
4 years, 8 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cpuid fix for nacl #

Patch Set 3 : merge with head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M source/cpu_id.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
fbarchard1
try bots pass Tihs addresses the NaCL build error: $ native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0 -Dlibyuv_disable_jpeg=1 ...
4 years, 8 months ago (2016-04-01 23:14:05 UTC) #1
fbarchard1
Committed patchset #3 (id:40001) manually as c7372a323a4606a53644250814374052baa5c679 (presubmit successful).
4 years, 8 months ago (2016-04-02 00:48:27 UTC) #4
kjellander_chromium
4 years, 8 months ago (2016-04-04 06:10:35 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698