|
Revert 254207 "Switch to using the new Link Doctor API."
This caused a memory leak. It appears |suggestions| was mismanaged?
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/13714/steps/unit_tests/logs/OfflinePageDontProceed
Direct leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x4b1711 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54
#1 0x61e7518 in LocalizedError::GetStrings(int, std::string const&, GURL const&, bool, bool, std::string const&, std::string const&, scoped_ptr\u003CLocalizedError::ErrorPageParams, base::DefaultDeleter\u003CLocalizedError::ErrorPageParams> >, base::DictionaryValue*) chrome/common/localized_error.cc:686
#2 0x111d82c0 in chromeos::OfflineLoadPage::GetHTMLContents() chrome/browser/chromeos/offline/offline_load_page.cc:98
#3 0xfb6f1fd in content::InterstitialPageImpl::Show() content/browser/frame_host/interstitial_page_impl.cc:248
#4 0x13fc43e in chromeos::OfflineLoadPageTest::ShowInterstitial(char const*) chrome/browser/chromeos/offline/offline_load_page_unittest.cc:71
#5 0x13fc870 in chromeos::OfflineLoadPageTest_OfflinePageDontProceed_Test::TestBody() chrome/browser/chromeos/offline/offline_load_page_unittest.cc:128
#6 0x800bf1a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
#7 0x800bf1a in testing::Test::Run() testing/gtest/src/gtest.cc:2061
#8 0x800e349 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
#9 0x800f0c3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
#10 0x801fd1a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
#11 0x801f320 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
#12 0x801f320 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
#13 0x129f3154 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
#14 0x129f3154 in base::TestSuite::Run() base/test/test_suite.cc:213
#15 0x129ea3b7 in Run base/callback.h:401
#16 0x129ea3b7 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
#17 0x820ee6d in main chrome/test/base/run_all_unittests.cc:13
#18 0x7f1d7d44d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226
> Switch to using the new Link Doctor API.
>
> The new API allows Link Doctor results to be integrated into Chrome's
> own error pages.
>
> BUG= 64832
> R=pkasting@chromium.org, thakis@chromium.org, tsepez@chromium.org, ttuttle@chromium.org
>
> Review URL: https://codereview.chromium.org/137623011
TBR=mmenke@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254241
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+501 lines, -1639 lines) |
Patch |
 |
M |
trunk/src/chrome/app/generated_resources.grd
|
View
|
|
3 chunks |
+7 lines, -18 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/errorpage_browsertest.cc
|
View
|
|
18 chunks |
+68 lines, -213 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/google/google_util.h
|
View
|
|
2 chunks |
+3 lines, -9 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/google/google_util.cc
|
View
|
|
3 chunks |
+19 lines, -43 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/net/dns_probe_browsertest.cc
|
View
|
|
26 chunks |
+121 lines, -144 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/net/url_request_mock_util.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/prefs/browser_prefs.cc
|
View
|
|
3 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/ui/alternate_error_tab_observer.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/ui/alternate_error_tab_observer.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/ui/navigation_correction_tab_observer.h
|
View
|
|
1 chunk |
+0 lines, -62 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/ui/navigation_correction_tab_observer.cc
|
View
|
|
1 chunk |
+0 lines, -99 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/ui/tab_helpers.cc
|
View
|
|
3 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser_ui.gypi
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/common/localized_error.h
|
View
|
|
3 chunks |
+2 lines, -24 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/common/localized_error.cc
|
View
|
|
7 chunks |
+33 lines, -75 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/common/render_messages.h
|
View
|
|
1 chunk |
+3 lines, -8 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/renderer/net/net_error_helper.h
|
View
|
|
2 chunks |
+9 lines, -19 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/renderer/net/net_error_helper.cc
|
View
|
|
9 chunks |
+25 lines, -56 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/renderer/net/net_error_helper_core.h
|
View
|
|
6 chunks |
+11 lines, -31 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/renderer/net/net_error_helper_core.cc
|
View
|
|
11 chunks |
+86 lines, -267 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/renderer/net/net_error_helper_core_unittest.cc
|
View
|
|
30 chunks |
+94 lines, -447 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/renderer/resources/neterror.css
|
View
|
|
8 chunks |
+11 lines, -58 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/renderer/resources/neterror.html
|
View
|
|
2 chunks |
+5 lines, -20 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/renderer/resources/neterror.js
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/test/data/mock-link-doctor.html
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/test/data/mock-link-doctor.json
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/test/data/mock-link-doctor.html.mock-http-headers
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/test/data/mock-link-doctor.json.mock-http-headers
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|