* gtk implemenation of tabbed pane...

* gtk implemenation of tabbed pane
 * focus is not handled as Jay is working on it.

[sky, 2009-09-02 17:40:03]

http://codereview.chromium.org/185003/diff/6001/6003
File views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right):

http://codereview.chromium.org/185003/diff/6001/6003#newcode33
Line 33: STLDeleteContainerPointers(tab_views_.begin(), tab_views_.end());
Rather than doing this, why not let the WidgetGtk you wrap each view in delete
them?

Also, do you really need tab_views_? Seems like you could get away without it.

http://codereview.chromium.org/185003/diff/6001/6003#newcode134
Line 134: g_object_ref(page);
Don't you need a corresponding unref after you add the page?

[oshima, 2009-09-02 19:01:49]

http://codereview.chromium.org/185003/diff/6001/6003
File views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right):

http://codereview.chromium.org/185003/diff/6001/6003#newcode33
Line 33: STLDeleteContainerPointers(tab_views_.begin(), tab_views_.end());
On 2009/09/02 17:40:03, sky wrote:
> Rather than doing this, why not let the WidgetGtk you wrap each view in delete
> them?
> 
> Also, do you really need tab_views_? Seems like you could get away without it.

Done.

http://codereview.chromium.org/185003/diff/6001/6003#newcode134
Line 134: g_object_ref(page);
On 2009/09/02 17:40:03, sky wrote:
> Don't you need a corresponding unref after you add the page?

Done. Just learned floating reference concept in gtk. thanks.

[sky, 2009-09-02 20:02:34]

Landed in r25222.

  -Scott

On Wed, Sep 2, 2009 at 12:01 PM, <oshima@chromium.org> wrote:
>
> http://codereview.chromium.org/185003/diff/6001/6003
> File views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right):
>
> http://codereview.chromium.org/185003/diff/6001/6003#newcode33
> Line 33: STLDeleteContainerPointers(tab_views_.begin(),
> tab_views_.end());
> On 2009/09/02 17:40:03, sky wrote:
>>
>> Rather than doing this, why not let the WidgetGtk you wrap each view
>
> in delete
>>
>> them?
>
>> Also, do you really need tab_views_? Seems like you could get away
>
> without it.
>
> Done.
>
> http://codereview.chromium.org/185003/diff/6001/6003#newcode134
> Line 134: g_object_ref(page);
> On 2009/09/02 17:40:03, sky wrote:
>>
>> Don't you need a corresponding unref after you add the page?
>
> Done. Just learned floating reference concept in gtk. thanks.
>
> http://codereview.chromium.org/185003
>