Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3511)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/usb/web_usb_device_impl.cc

Issue 1850023002: Consume Mojo services directly in Blink's WebUSB implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't do assignments in if statements. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/usb/web_usb_device_impl.h ('k') | device/usb/public/interfaces/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/usb/web_usb_device_impl.cc
diff --git a/content/renderer/usb/web_usb_device_impl.cc b/content/renderer/usb/web_usb_device_impl.cc
deleted file mode 100644
index 3f82b135e015e79891f689130ddcb9811a85d403..0000000000000000000000000000000000000000
--- a/content/renderer/usb/web_usb_device_impl.cc
+++ /dev/null
@@ -1,421 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "content/renderer/usb/web_usb_device_impl.h"
-
-#include <utility>
-
-#include "base/bind.h"
-#include "base/callback.h"
-#include "base/strings/utf_string_conversions.h"
-#include "content/child/mojo/type_converters.h"
-#include "content/child/scoped_web_callbacks.h"
-#include "content/renderer/usb/type_converters.h"
-#include "services/shell/public/cpp/connect.h"
-#include "services/shell/public/interfaces/connector.mojom.h"
-#include "third_party/WebKit/public/platform/WebVector.h"
-#include "third_party/WebKit/public/platform/modules/webusb/WebUSBDeviceInfo.h"
-#include "third_party/WebKit/public/platform/modules/webusb/WebUSBTransferInfo.h"
-
-namespace content {
-
-namespace {
-
-const char kClaimInterfaceFailed[] = "Unable to claim interface.";
-const char kClearHaltFailed[] = "Unable to clear endpoint.";
-const char kDeviceAlreadyOpen[] = "Device has already been opened.";
-const char kDeviceNoAccess[] = "Access denied.";
-const char kDeviceUnavailable[] = "Device unavailable.";
-const char kDeviceResetFailed[] = "Unable to reset the device.";
-const char kReleaseInterfaceFailed[] = "Unable to release interface.";
-const char kSetConfigurationFailed[] = "Unable to set device configuration.";
-const char kSetInterfaceFailed[] = "Unable to set device interface.";
-const char kTransferFailed[] = "Transfer failed.";
-
-// Generic default rejection handler for any WebUSB callbacks type. Assumes
-// |CallbacksType| is a blink::WebCallbacks<T, const blink::WebUSBError&>
-// for any type |T|.
-template <typename CallbacksType>
-void RejectWithError(const blink::WebUSBError& error,
- std::unique_ptr<CallbacksType> callbacks) {
- callbacks->onError(error);
-}
-
-template <typename CallbacksType>
-void RejectWithTransferError(std::unique_ptr<CallbacksType> callbacks) {
- RejectWithError(blink::WebUSBError(blink::WebUSBError::Error::Network,
- base::ASCIIToUTF16(kTransferFailed)),
- std::move(callbacks));
-}
-
-// Create a new ScopedWebCallbacks for WebUSB device callbacks, defaulting to
-// a "device unavailable" rejection.
-template <typename CallbacksType>
-ScopedWebCallbacks<CallbacksType> MakeScopedUSBCallbacks(
- CallbacksType* callbacks) {
- return make_scoped_web_callbacks(
- callbacks,
- base::Bind(&RejectWithError<CallbacksType>,
- blink::WebUSBError(blink::WebUSBError::Error::NotFound,
- base::ASCIIToUTF16(kDeviceUnavailable))));
-}
-
-void OnOpenDevice(
- ScopedWebCallbacks<blink::WebUSBDeviceOpenCallbacks> callbacks,
- device::usb::OpenDeviceError error) {
- auto scoped_callbacks = callbacks.PassCallbacks();
- switch(error) {
- case device::usb::OpenDeviceError::OK:
- scoped_callbacks->onSuccess();
- break;
- case device::usb::OpenDeviceError::ACCESS_DENIED:
- scoped_callbacks->onError(blink::WebUSBError(
- blink::WebUSBError::Error::Security,
- base::ASCIIToUTF16(kDeviceNoAccess)));
- break;
- case device::usb::OpenDeviceError::ALREADY_OPEN:
- scoped_callbacks->onError(blink::WebUSBError(
- blink::WebUSBError::Error::InvalidState,
- base::ASCIIToUTF16(kDeviceAlreadyOpen)));
- break;
- default:
- NOTREACHED();
- }
-}
-
-void OnDeviceClosed(
- ScopedWebCallbacks<blink::WebUSBDeviceCloseCallbacks> callbacks) {
- callbacks.PassCallbacks()->onSuccess();
-}
-
-void HandlePassFailDeviceOperation(
- ScopedWebCallbacks<blink::WebCallbacks<void, const blink::WebUSBError&>>
- callbacks,
- const std::string& failure_message,
- bool success) {
- auto scoped_callbacks = callbacks.PassCallbacks();
- if (success) {
- scoped_callbacks->onSuccess();
- } else {
- RejectWithError(blink::WebUSBError(blink::WebUSBError::Error::Network,
- base::ASCIIToUTF16(failure_message)),
- std::move(scoped_callbacks));
- }
-}
-
-void OnTransferIn(
- ScopedWebCallbacks<blink::WebUSBDeviceTransferCallbacks> callbacks,
- device::usb::TransferStatus status,
- mojo::Array<uint8_t> data) {
- auto scoped_callbacks = callbacks.PassCallbacks();
- blink::WebUSBTransferInfo::Status web_status;
- switch (status) {
- case device::usb::TransferStatus::COMPLETED:
- web_status = blink::WebUSBTransferInfo::Status::Ok;
- break;
- case device::usb::TransferStatus::STALLED:
- web_status = blink::WebUSBTransferInfo::Status::Stall;
- break;
- case device::usb::TransferStatus::BABBLE:
- web_status = blink::WebUSBTransferInfo::Status::Babble;
- break;
- default:
- RejectWithTransferError(std::move(scoped_callbacks));
- return;
- }
- std::unique_ptr<blink::WebUSBTransferInfo> info(
- new blink::WebUSBTransferInfo());
- info->status.assign(
- std::vector<blink::WebUSBTransferInfo::Status>(1, web_status));
- info->data.assign(data);
- scoped_callbacks->onSuccess(std::move(info));
-}
-
-void OnTransferOut(
- ScopedWebCallbacks<blink::WebUSBDeviceTransferCallbacks> callbacks,
- size_t bytes_written,
- device::usb::TransferStatus status) {
- auto scoped_callbacks = callbacks.PassCallbacks();
- blink::WebUSBTransferInfo::Status web_status;
- switch (status) {
- case device::usb::TransferStatus::COMPLETED:
- web_status = blink::WebUSBTransferInfo::Status::Ok;
- break;
- case device::usb::TransferStatus::STALLED:
- web_status = blink::WebUSBTransferInfo::Status::Stall;
- break;
- default:
- RejectWithTransferError(std::move(scoped_callbacks));
- return;
- }
- // TODO(rockot): Device::ControlTransferOut should expose the number of bytes
- // actually transferred so we can send it from here.
- std::unique_ptr<blink::WebUSBTransferInfo> info(
- new blink::WebUSBTransferInfo());
- info->status.assign(
- std::vector<blink::WebUSBTransferInfo::Status>(1, web_status));
- info->bytesTransferred.assign(std::vector<uint32_t>(1, bytes_written));
- scoped_callbacks->onSuccess(std::move(info));
-}
-
-void OnIsochronousTransferIn(
- ScopedWebCallbacks<blink::WebUSBDeviceTransferCallbacks> callbacks,
- mojo::Array<uint8_t> data,
- mojo::Array<device::usb::IsochronousPacketPtr> packets) {
- auto scoped_callbacks = callbacks.PassCallbacks();
- std::unique_ptr<blink::WebUSBTransferInfo> info(
- new blink::WebUSBTransferInfo());
- info->data.assign(data);
- info->status =
- blink::WebVector<blink::WebUSBTransferInfo::Status>(packets.size());
- info->packetLength = blink::WebVector<uint32_t>(packets.size());
- info->bytesTransferred = blink::WebVector<uint32_t>(packets.size());
- for (size_t i = 0; i < packets.size(); ++i) {
- switch (packets[i]->status) {
- case device::usb::TransferStatus::COMPLETED:
- info->status[i] = blink::WebUSBTransferInfo::Status::Ok;
- break;
- case device::usb::TransferStatus::STALLED:
- info->status[i] = blink::WebUSBTransferInfo::Status::Stall;
- break;
- case device::usb::TransferStatus::BABBLE:
- info->status[i] = blink::WebUSBTransferInfo::Status::Babble;
- break;
- default:
- RejectWithTransferError(std::move(scoped_callbacks));
- return;
- }
- info->packetLength[i] = packets[i]->length;
- info->bytesTransferred[i] = packets[i]->transferred_length;
- }
- scoped_callbacks->onSuccess(std::move(info));
-}
-
-void OnIsochronousTransferOut(
- ScopedWebCallbacks<blink::WebUSBDeviceTransferCallbacks> callbacks,
- mojo::Array<device::usb::IsochronousPacketPtr> packets) {
- auto scoped_callbacks = callbacks.PassCallbacks();
- std::unique_ptr<blink::WebUSBTransferInfo> info(
- new blink::WebUSBTransferInfo());
- info->status =
- blink::WebVector<blink::WebUSBTransferInfo::Status>(packets.size());
- info->bytesTransferred = blink::WebVector<uint32_t>(packets.size());
- for (size_t i = 0; i < packets.size(); ++i) {
- switch (packets[i]->status) {
- case device::usb::TransferStatus::COMPLETED:
- info->status[i] = blink::WebUSBTransferInfo::Status::Ok;
- break;
- case device::usb::TransferStatus::STALLED:
- info->status[i] = blink::WebUSBTransferInfo::Status::Stall;
- break;
- default:
- RejectWithTransferError(std::move(scoped_callbacks));
- return;
- }
- info->bytesTransferred[i] = packets[i]->transferred_length;
- }
- scoped_callbacks->onSuccess(std::move(info));
-}
-
-} // namespace
-
-WebUSBDeviceImpl::WebUSBDeviceImpl(device::usb::DevicePtr device,
- const blink::WebUSBDeviceInfo& device_info)
- : device_(std::move(device)),
- device_info_(device_info),
- weak_factory_(this) {
- if (device_)
- device_.set_connection_error_handler([this]() { device_.reset(); });
-}
-
-WebUSBDeviceImpl::~WebUSBDeviceImpl() {}
-
-const blink::WebUSBDeviceInfo& WebUSBDeviceImpl::info() const {
- return device_info_;
-}
-
-void WebUSBDeviceImpl::open(blink::WebUSBDeviceOpenCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (device_)
- device_->Open(base::Bind(&OnOpenDevice, base::Passed(&scoped_callbacks)));
-}
-
-void WebUSBDeviceImpl::close(blink::WebUSBDeviceCloseCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (device_)
- device_->Close(
- base::Bind(&OnDeviceClosed, base::Passed(&scoped_callbacks)));
-}
-
-void WebUSBDeviceImpl::setConfiguration(
- uint8_t configuration_value,
- blink::WebUSBDeviceSetConfigurationCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (device_)
- device_->SetConfiguration(
- configuration_value,
- base::Bind(&HandlePassFailDeviceOperation,
- base::Passed(&scoped_callbacks), kSetConfigurationFailed));
-}
-
-void WebUSBDeviceImpl::claimInterface(
- uint8_t interface_number,
- blink::WebUSBDeviceClaimInterfaceCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (device_)
- device_->ClaimInterface(
- interface_number,
- base::Bind(&HandlePassFailDeviceOperation,
- base::Passed(&scoped_callbacks), kClaimInterfaceFailed));
-}
-
-void WebUSBDeviceImpl::releaseInterface(
- uint8_t interface_number,
- blink::WebUSBDeviceReleaseInterfaceCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (device_)
- device_->ReleaseInterface(
- interface_number,
- base::Bind(&HandlePassFailDeviceOperation,
- base::Passed(&scoped_callbacks), kReleaseInterfaceFailed));
-}
-
-void WebUSBDeviceImpl::setInterface(
- uint8_t interface_number,
- uint8_t alternate_setting,
- blink::WebUSBDeviceSetInterfaceAlternateSettingCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (device_)
- device_->SetInterfaceAlternateSetting(
- interface_number, alternate_setting,
- base::Bind(&HandlePassFailDeviceOperation,
- base::Passed(&scoped_callbacks), kSetInterfaceFailed));
-}
-
-void WebUSBDeviceImpl::clearHalt(
- uint8_t endpoint_number,
- blink::WebUSBDeviceClearHaltCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (device_)
- device_->ClearHalt(
- endpoint_number,
- base::Bind(&HandlePassFailDeviceOperation,
- base::Passed(&scoped_callbacks), kClearHaltFailed));
-}
-
-void WebUSBDeviceImpl::controlTransfer(
- const blink::WebUSBDevice::ControlTransferParameters& parameters,
- uint8_t* data,
- size_t data_size,
- unsigned int timeout,
- blink::WebUSBDeviceTransferCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (!device_)
- return;
-
- device::usb::ControlTransferParamsPtr params =
- device::usb::ControlTransferParams::From(parameters);
- switch (parameters.direction) {
- case WebUSBDevice::TransferDirection::In:
- device_->ControlTransferIn(
- std::move(params), data_size, timeout,
- base::Bind(&OnTransferIn, base::Passed(&scoped_callbacks)));
- break;
- case WebUSBDevice::TransferDirection::Out: {
- std::vector<uint8_t> bytes;
- if (data)
- bytes.assign(data, data + data_size);
- mojo::Array<uint8_t> mojo_bytes;
- mojo_bytes.Swap(&bytes);
- device_->ControlTransferOut(
- std::move(params), std::move(mojo_bytes), timeout,
- base::Bind(&OnTransferOut, base::Passed(&scoped_callbacks),
- data_size));
- break;
- }
- default:
- NOTREACHED();
- }
-}
-
-void WebUSBDeviceImpl::transfer(
- blink::WebUSBDevice::TransferDirection direction,
- uint8_t endpoint_number,
- uint8_t* data,
- size_t data_size,
- unsigned int timeout,
- blink::WebUSBDeviceTransferCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (!device_)
- return;
-
- switch (direction) {
- case WebUSBDevice::TransferDirection::In:
- device_->GenericTransferIn(
- endpoint_number, data_size, timeout,
- base::Bind(&OnTransferIn, base::Passed(&scoped_callbacks)));
- break;
- case WebUSBDevice::TransferDirection::Out: {
- std::vector<uint8_t> bytes;
- if (data)
- bytes.assign(data, data + data_size);
- mojo::Array<uint8_t> mojo_bytes;
- mojo_bytes.Swap(&bytes);
- device_->GenericTransferOut(
- endpoint_number, std::move(mojo_bytes), timeout,
- base::Bind(&OnTransferOut, base::Passed(&scoped_callbacks),
- data_size));
- break;
- }
- default:
- NOTREACHED();
- }
-}
-
-void WebUSBDeviceImpl::isochronousTransfer(
- blink::WebUSBDevice::TransferDirection direction,
- uint8_t endpoint_number,
- uint8_t* data,
- size_t data_size,
- blink::WebVector<uint32_t> packet_lengths,
- unsigned int timeout,
- blink::WebUSBDeviceTransferCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (!device_)
- return;
-
- switch (direction) {
- case WebUSBDevice::TransferDirection::In:
- device_->IsochronousTransferIn(
- endpoint_number, mojo::Array<uint32_t>::From(packet_lengths), timeout,
- base::Bind(&OnIsochronousTransferIn,
- base::Passed(&scoped_callbacks)));
- break;
- case WebUSBDevice::TransferDirection::Out: {
- std::vector<uint8_t> bytes;
- if (data)
- bytes.assign(data, data + data_size);
- mojo::Array<uint8_t> mojo_bytes;
- mojo_bytes.Swap(&bytes);
- device_->IsochronousTransferOut(
- endpoint_number, std::move(mojo_bytes),
- mojo::Array<uint32_t>::From(packet_lengths), timeout,
- base::Bind(&OnIsochronousTransferOut,
- base::Passed(&scoped_callbacks)));
- break;
- }
- default:
- NOTREACHED();
- }
-}
-
-void WebUSBDeviceImpl::reset(blink::WebUSBDeviceResetCallbacks* callbacks) {
- auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
- if (device_)
- device_->Reset(base::Bind(&HandlePassFailDeviceOperation,
- base::Passed(&scoped_callbacks),
- kDeviceResetFailed));
-}
-
-} // namespace content
« no previous file with comments | « content/renderer/usb/web_usb_device_impl.h ('k') | device/usb/public/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698