content/browser/renderer_host/render_view_host_factory.h - Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_factory.h

Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: code review Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_delegate.cc ('k') | content/browser/renderer_host/render_view_host_factory.cc » ('j') | content/browser/web_contents/navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_factory.h

diff --git a/content/browser/renderer_host/render_view_host_factory.h b/content/browser/renderer_host/render_view_host_factory.h

index df61552a5e3b01d7fbc148a266283b16038b2d6c..6226187af537bfa830f6d09d6f77865c12d75349 100644

--- a/content/browser/renderer_host/render_view_host_factory.h

+++ b/content/browser/renderer_host/render_view_host_factory.h

@@ -29,8 +29,7 @@ class RenderViewHostFactory {

RenderWidgetHostDelegate* widget_delegate,

int routing_id,

int main_frame_routing_id,

- bool swapped_out,

- SessionStorageNamespace* session_storage);

+ bool swapped_out);

// Returns true if there is currently a globally-registered factory.

static bool has_factory() {

@@ -49,8 +48,7 @@ class RenderViewHostFactory {

RenderWidgetHostDelegate* widget_delegate,

int routing_id,

int main_frame_routing_id,

- bool swapped_out,

- SessionStorageNamespace* session_storage_namespace) = 0;

+ bool swapped_out) = 0;

// Registers your factory to be called when new RenderViewHosts are created.

// We have only one global factory, so there must be no factory registered