chrome/browser/sync/profile_sync_service_session_unittest.cc - Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_session_unittest.cc

Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: code review Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/tab_restore_service_helper.cc ('k') | chrome/browser/ui/browser_tabrestore.cc » ('j') | content/browser/web_contents/navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_session_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_session_unittest.cc b/chrome/browser/sync/profile_sync_service_session_unittest.cc

index ea8447fdceffc2275956ee9216517b33203fff71..65054851a2dcd30b2df965a91f0f5f83d190068f 100644

--- a/chrome/browser/sync/profile_sync_service_session_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_session_unittest.cc

@@ -1292,7 +1292,7 @@ TEST_F(ProfileSyncServiceSessionTest, CheckPrerenderedWebContentsSwap) {

// Create new WebContents, with the required tab helpers.

WebContents* new_web_contents = WebContents::CreateWithSessionStorage(

WebContents::CreateParams(profile()),

- old_web_contents->GetController().GetSessionStorageNamespaceMap());

+ old_web_contents->GetController().GetSessionStorageNamespace());

SessionTabHelper::CreateForWebContents(new_web_contents);

TabContentsSyncedTabDelegate::CreateForWebContents(new_web_contents);

new_web_contents->GetController()