Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6588)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 18500005: Fix SessionStorage confusion between RenderViewHostImpl and NavigationController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: code review Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 7e5f146822a4d9e3c88ddf080bc17a6d81482d5c..e93ccc9f622645bf311dc5fdaac1effaf951b42f 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -323,10 +323,8 @@ PrerenderHandle* PrerenderManager::AddPrerenderFromLinkRelPrerender(
return NULL;
if (source_web_contents->GetURL().host() == url.host())
origin = ORIGIN_LINK_REL_PRERENDER_SAMEDOMAIN;
- // TODO(ajwong): This does not correctly handle storage for isolated apps.
session_storage_namespace =
- source_web_contents->GetController()
- .GetDefaultSessionStorageNamespace();
+ source_web_contents->GetController().GetSessionStorageNamespace();
}
// If the prerender request comes from a recently cancelled prerender that
@@ -408,10 +406,8 @@ bool PrerenderManager::MaybeUsePrerenderedPage(WebContents* web_contents,
DeleteOldEntries();
to_delete_prerenders_.clear();
- // TODO(ajwong): This doesn't handle isolated apps correctly.
PrerenderData* prerender_data = FindPrerenderData(
- url,
- web_contents->GetController().GetDefaultSessionStorageNamespace());
+ url, web_contents->GetController().GetSessionStorageNamespace());
if (!prerender_data)
return false;
DCHECK(prerender_data->contents());

Powered by Google App Engine
This is Rietveld 408576698