Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 18500004: Remove ElementTimeControl IDL interface (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, f(malita), pdr, Stephen Chennney, do-not-use, lgombos, krit
Visibility:
Public.

Description

Remove ElementTimeControl IDL interface Remove ElementTimeControl IDL interface and move its attributes to the SVGAnimationElement IDL interface as per the latest SVG2 specification: https://svgwg.org/svg2-draft/animate.html#InterfaceSVGAnimationElement Also remove [NoInterfaceObject] IDL extended attribute from SVGAnimationElement as it is not present in the specification. This is one step towards removing IDL multiple inheritance in SVG. BUG=256618 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -92 lines) Patch
M LayoutTests/svg/custom/global-constructors-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/svg/ElementTimeControl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/svg/ElementTimeControl.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.h View 2 chunks +5 lines, -8 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.idl View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-02 13:17:47 UTC) #1
haraken
LGTM, but please wait for an approval from stephen.
7 years, 5 months ago (2013-07-02 13:31:36 UTC) #2
Stephen Chennney
lgtm
7 years, 5 months ago (2013-07-02 21:12:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18500004/1
7 years, 5 months ago (2013-07-02 21:12:40 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 23:28:15 UTC) #5
Message was sent while issue was closed.
Change committed as 153458

Powered by Google App Engine
This is Rietveld 408576698