Fix the way generated code is made strong mode clean

Fix the way generated code is made strong mode clean

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/cbcb689184a4738edc967d4e539ea11ec99aa520

[Brian Wilkerson, 2016-03-31 19:40:07]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Brian Wilkerson, 2016-03-31 19:40:07]

As per your review comment.

[Paul Berry, 2016-03-31 19:44:03]

https://codereview.chromium.org/1849973002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol/protocol_internal.dart (right):

https://codereview.chromium.org/1849973002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol/protocol_internal.dart:318:
result.add(decoder('$jsonPath[$i]', json[i]) as Object/*=E*/);
Could we also get rid of this cast by parameterizing JsonDecoderCallback? (In
other words, change the signature on decodeList above to "...,
[JsonDecoderCallback<E> decoder])")

https://codereview.chromium.org/1849973002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol/protocol_internal.dart:339: decodedKey =
keyDecoder('$jsonPath.key', key) as Object/*=K*/;
Similar question here.

[Brian Wilkerson, 2016-03-31 19:51:35]

https://codereview.chromium.org/1849973002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol/protocol_internal.dart (right):

https://codereview.chromium.org/1849973002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol/protocol_internal.dart:318:
result.add(decoder('$jsonPath[$i]', json[i]) as Object/*=E*/);
Yes. Done.

https://codereview.chromium.org/1849973002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol/protocol_internal.dart:339: decodedKey =
keyDecoder('$jsonPath.key', key) as Object/*=K*/;
Done.

[Brian Wilkerson, 2016-03-31 20:21:58]

ptal

[Paul Berry, 2016-03-31 20:37:17]

lgtm

[Brian Wilkerson, 2016-03-31 20:43:10]

Description was changed from

==========
Fix the way generated code is made strong mode clean
==========

to

==========
Fix the way generated code is made strong mode clean

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cbcb689184a4738edc967d4e539ea11ec99aa520
==========

[Brian Wilkerson, 2016-03-31 20:43:12]

Committed patchset #2 (id:20001) manually as
cbcb689184a4738edc967d4e539ea11ec99aa520 (presubmit successful).