Issue 184993008: Rename libvpx_untrusted->libvpx_nacl. Disable non-portable NaCl build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 184993008: Rename libvpx_untrusted->libvpx_nacl. Disable non-portable NaCl build. (Closed)

Created:
6 years, 9 months ago by Sergey Ulanov

Modified:
6 years, 9 months ago

Reviewers:
Tom Finegan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/libvpx

Visibility:
Public.

Rename libvpx_untrusted->libvpx_nacl. Disable non-portable NaCl build. Renaming the NaCl target for consistency with other NaCl targets in chromium. Also disabled all build types except PNaCl: Chromoting will only build BUG=345453 R=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254612

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -41 lines)			Patch
	A +	libvpx_nacl.gyp	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	D	libvpx_untrusted.gyp	View		1 chunk	+0 lines, -36 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Finegan

lgtm Sorry for the review delay: Tough battle with the flu at the end of ...

6 years, 9 months ago (2014-03-03 23:47:20 UTC) #2

Sergey Ulanov

6 years, 9 months ago (2014-03-04 00:04:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r254612 (presubmit successful).