Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: chrome/browser/sync/test/integration/profile_sync_service_harness.h

Issue 184993006: sync: Change progress marker checking in tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/profile_sync_service_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/profile_sync_service_harness.h
diff --git a/chrome/browser/sync/test/integration/profile_sync_service_harness.h b/chrome/browser/sync/test/integration/profile_sync_service_harness.h
index 7786a09ae95d3e545d56044d3f11990d855c8bf1..de60336dd6d8f1683d09e2d83f77fb9f503230e5 100644
--- a/chrome/browser/sync/test/integration/profile_sync_service_harness.h
+++ b/chrome/browser/sync/test/integration/profile_sync_service_harness.h
@@ -88,10 +88,6 @@ class ProfileSyncServiceHarness
// true if sync setup is complete.
bool AwaitSyncSetupCompletion();
- // Blocks the caller until this harness has observed that the sync engine
- // has downloaded all the changes seen by the |partner| harness's client.
- bool WaitUntilProgressMarkersMatch(ProfileSyncServiceHarness* partner);
-
// Calling this acts as a barrier and blocks the caller until |this| and
// |partner| have both completed a sync cycle. When calling this method,
// the |partner| should be the passive responder who responds to the actions
@@ -187,10 +183,6 @@ class ProfileSyncServiceHarness
// available), annotated with |message|. Useful for logging.
std::string GetClientInfoString(const std::string& message) const;
- // Returns true if this client has downloaded all the items that the
- // other client has.
- bool MatchesPartnerClient() const;
-
private:
ProfileSyncServiceHarness(
Profile* profile,
@@ -210,10 +202,6 @@ class ProfileSyncServiceHarness
// found.
std::string GetSerializedProgressMarker(syncer::ModelType model_type) const;
- // Returns true if a client has nothing left to commit and its progress
- // markers are up to date.
- bool HasLatestProgressMarkers() const;
-
// Gets detailed status from |service_| in pretty-printable form.
std::string GetServiceStatus();
@@ -226,10 +214,6 @@ class ProfileSyncServiceHarness
// An bridge between the ProfileSyncService and P2PInvalidationService.
scoped_ptr<P2PInvalidationForwarder> p2p_invalidation_forwarder_;
- // The harness of the client whose update progress marker we're expecting
- // eventually match.
- ProfileSyncServiceHarness* progress_marker_partner_;
-
// Credentials used for GAIA authentication.
std::string username_;
std::string password_;
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/profile_sync_service_harness.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698