Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1849903002:
Perform Git operations without changing CWD. (Closed)
|
Created:
4 years, 8 months ago by dnj Modified:
4 years, 8 months ago CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org Base URL:
https://github.com/luci/recipes-py@master Target Ref:
refs/heads/master Project:
recipes-py Visibility:
Public. |
DescriptionPerform Git operations without changing CWD.
NOPRESUBMIT=True
BUG=chromium:599512
TEST=None
Committed: https://github.com/luci/recipes-py/commit/a0a8bda889b1eef6fa19d17b0d083044286ed5a9
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix all call sites, run everything through subprocess.check_output. #Patch Set 3 : Cleaner. #
Messages
Total messages: 23 (13 generated)
dnj@chromium.org changed reviewers: + iannucci@chromium.org, martiniss@chromium.org
PTAL
phajdan.jr@chromium.org changed reviewers: + phajdan.jr@chromium.org
https://codereview.chromium.org/1849903002/diff/1/recipe_engine/package.py File recipe_engine/package.py (right): https://codereview.chromium.org/1849903002/diff/1/recipe_engine/package.py#ne... recipe_engine/package.py:265: self.run_git(self._dep_dir(context), fetch) Shouldn't fetch be changed to 'fetch'? Just checking.
https://codereview.chromium.org/1849903002/diff/1/recipe_engine/package.py File recipe_engine/package.py (right): https://codereview.chromium.org/1849903002/diff/1/recipe_engine/package.py#ne... recipe_engine/package.py:265: self.run_git(self._dep_dir(context), fetch) On 2016/03/31 17:35:37, Paweł Hajdan Jr. wrote: > Shouldn't fetch be changed to 'fetch'? Just checking. Done.
sergiyb@chromium.org changed reviewers: + sergiyb@chromium.org
lgtm
lgtm
The CQ bit was checked by dnj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org Link to the patchset: https://codereview.chromium.org/1849903002/#ps40001 (title: "Cleaner.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849903002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/...)
Description was changed from ========== Perform Git operations without changing CWD. BUG=chromium:599512 TEST=None ========== to ========== Perform Git operations without changing CWD. NOPRESUBMIT=True BUG=chromium:599512 TEST=None ==========
Description was changed from ========== Perform Git operations without changing CWD. NOPRESUBMIT=True BUG=chromium:599512 TEST=None ========== to ========== Perform Git operations without changing CWD. NOTRY=True BUG=chromium:599512 TEST=None ==========
The CQ bit was checked by dnj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849903002/40001
Description was changed from ========== Perform Git operations without changing CWD. NOTRY=True BUG=chromium:599512 TEST=None ========== to ========== Perform Git operations without changing CWD. NOPRESUBMIT=True BUG=chromium:599512 TEST=None ==========
The CQ bit was unchecked by dnj@chromium.org
The CQ bit was checked by dnj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849903002/40001
Message was sent while issue was closed.
Description was changed from ========== Perform Git operations without changing CWD. NOPRESUBMIT=True BUG=chromium:599512 TEST=None ========== to ========== Perform Git operations without changing CWD. NOPRESUBMIT=True BUG=chromium:599512 TEST=None Committed: https://github.com/luci/recipes-py/commit/a0a8bda889b1eef6fa19d17b0d083044286... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://github.com/luci/recipes-py/commit/a0a8bda889b1eef6fa19d17b0d083044286... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
