Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1849843002: Rework computing simple strings difference. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -19 lines) Patch
M pkg/analysis_server/lib/src/services/correction/sort_members.dart View 1 chunk +3 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/strings.dart View 2 chunks +30 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/strings_test.dart View 2 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-03-31 16:40:45 UTC) #1
Brian Wilkerson
LGTM
4 years, 8 months ago (2016-03-31 16:57:39 UTC) #2
scheglov
4 years, 8 months ago (2016-03-31 17:18:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
559bc17535f5d85243540466a63d8a0cb36fdc6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698