Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 184983003: Update WebInputEventFactory on Mac for pinch gesture support (Closed)

Created:
6 years, 9 months ago by Rick Byers
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nico, Alexei Svitkine (slow)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update WebInputEventFactory on Mac for pinch gesture support WebInputEventFactory::gestureEvent was added a long time ago but is not currently used. Remove the existing unused code and update the function to support creating GesturePinchUpdate events from Cocoa NSEventTypeMagnify events. BUG=289887 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M Source/web/WebInputEventFactoryMac.mm View 2 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Rick Byers
Adam, please review this little change to WebInputEventFactory::gestureEvent. I talked to asvitkine@ who originally added ...
6 years, 9 months ago (2014-03-04 21:49:00 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-04 22:08:01 UTC) #2
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 9 months ago (2014-03-04 22:09:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/184983003/1
6 years, 9 months ago (2014-03-04 22:10:41 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 14:56:34 UTC) #5
Message was sent while issue was closed.
Change committed as 168482

Powered by Google App Engine
This is Rietveld 408576698