Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: components/cronet/android/api/src/org/chromium/net/UserAgent.java

Issue 1849753002: [Cronet] Separate Cronet implementation and API by package name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/UserAgent.java
diff --git a/components/cronet/android/api/src/org/chromium/net/UserAgent.java b/components/cronet/android/api/src/org/chromium/net/UserAgent.java
index 6dbab542c067b228f614a637a7f07c8a4ad378d2..5abd81c93277195082a2aa8401ab1bd7bc6826f8 100644
--- a/components/cronet/android/api/src/org/chromium/net/UserAgent.java
+++ b/components/cronet/android/api/src/org/chromium/net/UserAgent.java
@@ -57,8 +57,8 @@ final class UserAgent {
builder.append(id);
}
- builder.append("; Cronet/");
- builder.append(Version.CRONET_VERSION);
+ builder.append(";");
+ appendCronetVersion(builder);
builder.append(')');
@@ -76,8 +76,7 @@ final class UserAgent {
// Application name and cronet version.
builder.append(context.getPackageName());
- builder.append(" Cronet/");
- builder.append(Version.CRONET_VERSION);
+ appendCronetVersion(builder);
return builder.toString();
}
@@ -99,4 +98,14 @@ final class UserAgent {
return sVersionCode;
}
}
+
+ private static void appendCronetVersion(StringBuilder builder) {
+ builder.append(" Cronet/");
+ // TODO(pauljensen): This is the API version not the implementation
+ // version. The implementation version may be more appropriate for the
+ // UserAgent but is not available until after the CronetEngine is
+ // instantiated. Down the road, if the implementation is loaded via
+ // other means, this should be replaced with the implementation version.
+ builder.append(ApiVersion.CRONET_VERSION);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698