Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Unified Diff: components/cronet/android/BUILD.gn

Issue 1849753002: [Cronet] Separate Cronet implementation and API by package name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index dece98533f630a4238816b03b8b0ff065fbf9bc3..03c93d78f1260d042b5c6b52c99f3e8cf59d95a2 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -19,13 +19,13 @@ declare_args() {
generate_jni("cronet_jni_headers") {
sources = [
- "java/src/org/chromium/net/ChromiumUrlRequest.java",
- "java/src/org/chromium/net/ChromiumUrlRequestContext.java",
- "java/src/org/chromium/net/CronetBidirectionalStream.java",
- "java/src/org/chromium/net/CronetLibraryLoader.java",
- "java/src/org/chromium/net/CronetUploadDataStream.java",
- "java/src/org/chromium/net/CronetUrlRequest.java",
- "java/src/org/chromium/net/CronetUrlRequestContext.java",
+ "java/src/org/chromium/net/impl/ChromiumUrlRequest.java",
+ "java/src/org/chromium/net/impl/ChromiumUrlRequestContext.java",
+ "java/src/org/chromium/net/impl/CronetBidirectionalStream.java",
+ "java/src/org/chromium/net/impl/CronetLibraryLoader.java",
+ "java/src/org/chromium/net/impl/CronetUploadDataStream.java",
+ "java/src/org/chromium/net/impl/CronetUrlRequest.java",
+ "java/src/org/chromium/net/impl/CronetUrlRequestContext.java",
]
jni_package = "cronet"
}
@@ -76,23 +76,45 @@ java_cpp_template("load_states_list") {
package_name = "org/chromium/net"
}
-_generated_version_java_dir = "$target_gen_dir/templates/cronet_version_java"
-_generated_version_java =
- "$_generated_version_java_dir/org/chromium/net/Version.java"
+_generated_api_version_java_dir =
+ "$target_gen_dir/templates/cronet_api_version_java"
+_generated_api_version_java =
+ "$_generated_api_version_java_dir/org/chromium/net/ApiVersion.java"
-process_version("cronet_version_java") {
- template_file = "java/src/org/chromium/net/Version.template"
- output = _generated_version_java
+process_version("cronet_api_version_java") {
+ template_file = "api/src/org/chromium/net/ApiVersion.template"
+ output = _generated_api_version_java
}
-zip("cronet_version_srcjar") {
+zip("cronet_api_version_srcjar") {
inputs = [
- _generated_version_java,
+ _generated_api_version_java,
]
output = "$target_gen_dir/$target_name.srcjar"
- base_dir = _generated_version_java_dir
+ base_dir = _generated_api_version_java_dir
deps = [
- ":cronet_version_java",
+ ":cronet_api_version_java",
+ ]
+}
+
+_generated_impl_version_java_dir =
+ "$target_gen_dir/templates/cronet_impl_version_java"
+_generated_impl_version_java =
+ "$_generated_impl_version_java_dir/org/chromium/net/impl/ImplVersion.java"
+
+process_version("cronet_impl_version_java") {
+ template_file = "java/src/org/chromium/net/impl/ImplVersion.template"
+ output = _generated_impl_version_java
+}
+
+zip("cronet_impl_version_srcjar") {
+ inputs = [
+ _generated_impl_version_java,
+ ]
+ output = "$target_gen_dir/$target_name.srcjar"
+ base_dir = _generated_impl_version_java_dir
+ deps = [
+ ":cronet_impl_version_java",
]
}
@@ -278,7 +300,7 @@ android_library("cronet_api") {
]
srcjar_deps = [
- ":cronet_version_srcjar",
+ ":cronet_api_version_srcjar",
":http_cache_type_java",
":url_request_error_java",
":load_states_list",
@@ -290,14 +312,14 @@ android_library("cronet_api") {
android_library("cronet_java") {
java_files = [
- "java/src/org/chromium/net/ChromiumUrlRequest.java",
- "java/src/org/chromium/net/ChromiumUrlRequestContext.java",
- "java/src/org/chromium/net/ChromiumUrlRequestFactory.java",
- "java/src/org/chromium/net/CronetBidirectionalStream.java",
- "java/src/org/chromium/net/CronetLibraryLoader.java",
- "java/src/org/chromium/net/CronetUploadDataStream.java",
- "java/src/org/chromium/net/CronetUrlRequest.java",
- "java/src/org/chromium/net/CronetUrlRequestContext.java",
+ "java/src/org/chromium/net/impl/ChromiumUrlRequest.java",
+ "java/src/org/chromium/net/impl/ChromiumUrlRequestContext.java",
+ "java/src/org/chromium/net/impl/ChromiumUrlRequestFactory.java",
+ "java/src/org/chromium/net/impl/CronetBidirectionalStream.java",
+ "java/src/org/chromium/net/impl/CronetLibraryLoader.java",
+ "java/src/org/chromium/net/impl/CronetUploadDataStream.java",
+ "java/src/org/chromium/net/impl/CronetUrlRequest.java",
+ "java/src/org/chromium/net/impl/CronetUrlRequestContext.java",
"java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java",
"java/src/org/chromium/net/urlconnection/CronetChunkedOutputStream.java",
"java/src/org/chromium/net/urlconnection/CronetFixedModeOutputStream.java",
@@ -318,6 +340,7 @@ android_library("cronet_java") {
]
srcjar_deps = [
+ ":cronet_impl_version_srcjar",
":chromium_url_request_java",
":net_request_priority_java",
]

Powered by Google App Engine
This is Rietveld 408576698