Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849743002: [NTP Snippets] Add a flag to not restrict snippets by ML suggestions (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mcwilliams
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add a flag to not restrict snippets by ML suggestions BUG=599127 Committed: https://crrev.com/862f24c92d0a7df5dcc5a3c49bfc602ed9bedb4f Cr-Commit-Position: refs/heads/master@{#384249}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M components/ntp_snippets/ntp_snippets_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/ntp_snippets/switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/ntp_snippets/switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849743002/1
4 years, 8 months ago (2016-03-31 09:54:15 UTC) #2
Marc Treib
4 years, 8 months ago (2016-03-31 09:56:47 UTC) #4
Bernhard Bauer
lgtm https://codereview.chromium.org/1849743002/diff/1/components/ntp_snippets/switches.cc File components/ntp_snippets/switches.cc (right): https://codereview.chromium.org/1849743002/diff/1/components/ntp_snippets/switches.cc#newcode17 components/ntp_snippets/switches.cc:17: const char kDontRestrict[] = "ntp-snippets-dont-restrict"; Add a comment?
4 years, 8 months ago (2016-03-31 10:10:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 10:48:28 UTC) #7
Marc Treib
https://codereview.chromium.org/1849743002/diff/1/components/ntp_snippets/switches.cc File components/ntp_snippets/switches.cc (right): https://codereview.chromium.org/1849743002/diff/1/components/ntp_snippets/switches.cc#newcode17 components/ntp_snippets/switches.cc:17: const char kDontRestrict[] = "ntp-snippets-dont-restrict"; On 2016/03/31 10:10:58, Bernhard ...
4 years, 8 months ago (2016-03-31 11:01:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849743002/20001
4 years, 8 months ago (2016-03-31 11:01:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 11:58:59 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/862f24c92d0a7df5dcc5a3c49bfc602ed9bedb4f Cr-Commit-Position: refs/heads/master@{#384249}
4 years, 8 months ago (2016-03-31 12:01:27 UTC) #14
mcwilliams
4 years, 8 months ago (2016-03-31 16:39:29 UTC) #16
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698