Set the correct opener for window.open when calling window != window.

Set the correct opener for window.open when calling window != window.

This plumbing has been incorrect for a long time, but the problem was
masked by code made redundant in r378508. Prior to that, the embedder
would incorrectly set the calling window as the opener, but Blink would
later overwrite it with the correct opener.

BUG=595344
R=japhet@chromium.org, jochen@chromium.org

Committed: https://crrev.com/d2fc83084f01d0cb24de7352ca38dbeab2ca6060
Cr-Commit-Position: refs/heads/master@{#384298}

[dcheng, 2016-03-31 06:59:19]

Description was changed from

==========
Set the correct opener for window.open when calling window != window.

This plumbing has been incorrect for a long time, but the problem was
masked by code made redundant in r378508. Prior to that, the embedder
would incorrectly set the calling window as the opener, but Blink would
later overwrite it with the correct opener.

BUG=595344
R=japhet@chromium.org
==========

to

==========
Set the correct opener for window.open when calling window != window.

This plumbing has been incorrect for a long time, but the problem was
masked by code made redundant in r378508. Prior to that, the embedder
would incorrectly set the calling window as the opener, but Blink would
later overwrite it with the correct opener.

BUG=595344
R=japhet@chromium.org, jochen@chromium.org
==========

[dcheng, 2016-03-31 06:59:19]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org

[dcheng, 2016-03-31 06:59:23]

https://codereview.chromium.org/1849703002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/synchronous-frame-load-in-javascript-url-inherits-correct-origin-expected.txt
(right):

https://codereview.chromium.org/1849703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/synchronous-frame-load-in-javascript-url-inherits-correct-origin-expected.txt:1:
CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
accessing a frame with origin "http://localhost:8080". Protocols, domains, and
ports must match.
This changes back to the original expected result before
https://codereview.chromium.org/1685003002, since opener is now correctly
plumbed through.

I also added another test to make the failure condition obvious.

[jochen (gone - plz use gerrit), 2016-03-31 15:17:03]

lgtm

[dcheng, 2016-03-31 15:27:44]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-03-31 15:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849703002/20001

[commit-bot: I haz the power, 2016-03-31 16:13:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 16:15:11]

Description was changed from

==========
Set the correct opener for window.open when calling window != window.

This plumbing has been incorrect for a long time, but the problem was
masked by code made redundant in r378508. Prior to that, the embedder
would incorrectly set the calling window as the opener, but Blink would
later overwrite it with the correct opener.

BUG=595344
R=japhet@chromium.org, jochen@chromium.org
==========

to

==========
Set the correct opener for window.open when calling window != window.

This plumbing has been incorrect for a long time, but the problem was
masked by code made redundant in r378508. Prior to that, the embedder
would incorrectly set the calling window as the opener, but Blink would
later overwrite it with the correct opener.

BUG=595344
R=japhet@chromium.org, jochen@chromium.org

Committed: https://crrev.com/d2fc83084f01d0cb24de7352ca38dbeab2ca6060
Cr-Commit-Position: refs/heads/master@{#384298}
==========

[commit-bot: I haz the power, 2016-03-31 16:15:12]

Patchset 2 (id:??) landed as
https://crrev.com/d2fc83084f01d0cb24de7352ca38dbeab2ca6060
Cr-Commit-Position: refs/heads/master@{#384298}