Handlify JSObject::DefineAccessor method.

Handlify JSObject::DefineAccessor method.

R=rossberg@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=15458

[rossberg, 2013-07-02 12:20:47]

LGTM with comments

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc
File src/objects.cc (left):

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#oldcode6097
src/objects.cc:6097: // From this point on everything needs to be handlified.
Glad this goes away...

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#newcode5923
src/objects.cc:5923: return
AccessorPair::Copy(Handle<AccessorPair>(AccessorPair::cast(obj)));
Use handle() and pass isolate.

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#newcode5943
src/objects.cc:5943: ? Handle<Object>(factory->undefined_value())
Pass isolate. Though actually, isn't the constructor redundant here?

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#newcode5947
src/objects.cc:5947: ? Handle<Object>(factory->undefined_value())
Same here

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#newcode6238
src/objects.cc:6238: ?
AccessorPair::Copy(Handle<AccessorPair>(source_accessors))
Pass isolate

[Michael Starzinger, 2013-07-02 15:50:23]

Thanks. Addressed. Landing.

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#newcode5923
src/objects.cc:5923: return
AccessorPair::Copy(Handle<AccessorPair>(AccessorPair::cast(obj)));
On 2013/07/02 12:20:47, rossberg wrote:
> Use handle() and pass isolate.

Done.

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#newcode5943
src/objects.cc:5943: ? Handle<Object>(factory->undefined_value())
On 2013/07/02 12:20:47, rossberg wrote:
> Pass isolate. Though actually, isn't the constructor redundant here?

Done. As discussed offline: Returning an object here is obsolete, so let's
switch the return value of DefineFastAccessor to be a boolean value instead.

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#newcode5947
src/objects.cc:5947: ? Handle<Object>(factory->undefined_value())
On 2013/07/02 12:20:47, rossberg wrote:
> Same here

Likewise.

https://codereview.chromium.org/18497003/diff/2001/src/objects.cc#newcode6238
src/objects.cc:6238: ?
AccessorPair::Copy(Handle<AccessorPair>(source_accessors))
On 2013/07/02 12:20:47, rossberg wrote:
> Pass isolate

As discussed offline: Not needed here.

[Michael Starzinger, 2013-07-02 16:24:30]

Committed patchset #3 manually as r15458 (presubmit successful).