Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 1849693002: Force ENABLE_OILPAN regardless of enable_oilpan (Closed)

Created:
4 years, 8 months ago by haraken
Modified:
4 years, 8 months ago
Reviewers:
tkent, oilpan-reviews
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force ENABLE_OILPAN regardless of enable_oilpan This is a preparation for removing WillBe types. BUG=585328 Committed: https://crrev.com/0bb70155953b439896dce29f2b093be1bda23c6c Cr-Commit-Position: refs/heads/master@{#384234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M third_party/WebKit/Source/build/features.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/config.gni View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
haraken
PTAL I realized it's unrealistic to land the huge CL in one go. I'll land ...
4 years, 8 months ago (2016-03-31 02:26:05 UTC) #2
haraken
4 years, 8 months ago (2016-03-31 02:26:40 UTC) #4
tkent
lgtm
4 years, 8 months ago (2016-03-31 02:27:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849693002/1
4 years, 8 months ago (2016-03-31 02:32:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/151266)
4 years, 8 months ago (2016-03-31 02:46:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849693002/1
4 years, 8 months ago (2016-03-31 03:13:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849693002/1
4 years, 8 months ago (2016-03-31 08:13:00 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/196754)
4 years, 8 months ago (2016-03-31 08:34:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849693002/1
4 years, 8 months ago (2016-03-31 08:36:26 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 09:52:53 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 09:53:55 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bb70155953b439896dce29f2b093be1bda23c6c
Cr-Commit-Position: refs/heads/master@{#384234}

Powered by Google App Engine
This is Rietveld 408576698