third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp - Issue 1849653003: Implement ComputedStylePropertyMap for Typed OM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

Issue 1849653003: Implement ComputedStylePropertyMap for Typed OM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maps-inline

Patch Set: Update LayoutTests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h ('k') | third_party/WebKit/Source/core/css/cssom/WindowGetComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

index cbed9f2db09c93669e74c6dde6b38b4a2675c4c6..980c001aa355b35782d8dde72bd17f7dbd9de122 100644

--- a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

@@ -43,7 +43,7 @@ bool StylePropertyMap::has(const String& propertyName, ExceptionState& exception

{

CSSPropertyID propertyID = cssPropertyID(propertyName);

if (propertyID != CSSPropertyInvalid)

- return has(propertyID);

+ return !getAll(propertyID).isEmpty();

// TODO(meade): Handle custom properties here.

exceptionState.throwTypeError("Invalid propertyName: " + propertyName);