Implement ComputedStylePropertyMap for Typed OM.

third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp

Index: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..4cbaab0536a60b93869135d7a3a28a4cf7f08e61
--- /dev/null
+++ b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
@@ -0,0 +1,36 @@
+// Copyright 2016 the Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/css/cssom/ComputedStylePropertyMap.h"
+
+#include "core/css/CSSComputedStyleDeclaration.h"
+#include "core/css/cssom/StyleValueFactory.h"
+
+namespace blink {
+
+StylePropertyMap::StyleValueVector ComputedStylePropertyMap::getAll(CSSPropertyID propertyID)
+{
+    CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
+    return cssValueToStyleValueVector(propertyID, *cssValue);
+}
+
+bool ComputedStylePropertyMap::has(CSSPropertyID propertyID)
+{
+    CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
+    if (!cssValue)
+        return false;
+
+    return (!cssValue->isValueList() || toCSSValueList(cssValue)->length() > 0);

[Timothy Loh, 2016/05/13 02:08:23]

Commenting on this again - let's just change it to return cssValue. I think it's
actively misleading to do this sort of check.

This function should also be tested, at least have a couple cases where it
returns true and a couple cases where it returns false (in particular, comes
through here and returns false, since unknown properties names will fail
earlier). Some properties like max-zoom will return false here, but probably a
better test is setting something like "border: yellow; border-top-color: blue"
and checking border (I assume this is also invalid in typed OM?)

[meade_UTC10, 2016/05/13 05:05:31]

I changed this to use the base class version instead - in the other CL we
decided to return false if we couldn't represent a value in typed OM. 

I added some basic tests, but you can't use shorthands in typed OM, so your
colour example doesn't work as a testcase. Any other ideas?

+}
+
+Vector<String> ComputedStylePropertyMap::getProperties()
+{
+    Vector<String> result;
+    for (unsigned i = 0; i < m_computedStyleDeclaration->length(); i++) {
+        result.append(m_computedStyleDeclaration->item(i));
+    }
+    return result;
+}
+
+} // namespace blink