Implement ComputedStylePropertyMap for Typed OM.

third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/InlineStylePropertyMap.h"
 
 #include "core/CSSPropertyNames.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/CSSPropertyMetadata.h"
 #include "core/css/CSSValueList.h"
 #include "core/css/StylePropertySet.h"
 #include "core/css/cssom/CSSOMTypes.h"
 #include "core/css/cssom/SimpleLength.h"
 #include "core/css/cssom/StyleValueFactory.h"
 
 namespace blink {
 
-StyleValue* InlineStylePropertyMap::get(CSSPropertyID propertyID)
-{
-    ASSERT(propertyID != CSSPropertyInvalid);
-
-    StyleValueVector styleVector = getAll(propertyID);
-    if (styleVector.isEmpty())
-        return nullptr;
-
-    return styleVector.at(0);
-}
-
 StyleValueVector InlineStylePropertyMap::getAll(CSSPropertyID propertyID)
 {
     ASSERT(propertyID != CSSPropertyInvalid);
 
     RefPtrWillBeRawPtr<CSSValue> cssValue = m_ownerElement->ensureMutableInlineStyle().getPropertyCSSValue(propertyID);
     if (!cssValue)
         return StyleValueVector();
 
-    StyleValueVector styleValueVector;
-
-    if (!cssValue->isValueList()) {
-        StyleValue* styleValue = StyleValueFactory::create(propertyID, *cssValue);
-        if (styleValue)
-            styleValueVector.append(styleValue);
-        return styleValueVector;
-    }
-
-    for (auto& value : *toCSSValueList(cssValue.get())) {
-        StyleValue* styleValue = StyleValueFactory::create(propertyID, *value);
-        if (styleValue)
-            styleValueVector.append(styleValue);
-    }
-
-    return styleValueVector;
+    return cssValueToStyleValueVector(propertyID, *cssValue);
 }
 
 bool InlineStylePropertyMap::has(CSSPropertyID propertyID)
 {
     ASSERT(propertyID != CSSPropertyInvalid);
-    return !getAll(propertyID).isEmpty();
+
+    RefPtrWillBeRawPtr<CSSValue> cssValue = m_ownerElement->ensureMutableInlineStyle().getPropertyCSSValue(propertyID);
+    if (!cssValue)
+        return false;
+
+    return (!cssValue->isValueList() || toCSSValueList(cssValue)->length() > 0);

[Timothy Loh, 2016/03/31 06:59:25]

CSSValueLists are never empty (if you're setting empty CSSValueLists, something
is probably going to break)

[meade_UTC10, 2016/04/04 03:32:41]

Acknowledged. Seems best to look at that case though, just in case something
weird is going on. Would it be better to add an assert instead?

[Timothy Loh, 2016/04/15 04:16:07]

Why would this function care about whether the value is a CSSValueList at all
though?

 }
 
 Vector<String> InlineStylePropertyMap::getProperties()
 {
     Vector<String> result;
     StylePropertySet& inlineStyleSet = m_ownerElement->ensureMutableInlineStyle();
     for (unsigned i = 0; i < inlineStyleSet.propertyCount(); i++) {
         CSSPropertyID propertyID = inlineStyleSet.propertyAt(i).id();
         result.append(getPropertyNameString(propertyID));
     }
@@ skipping 85 matching lines @@
 }
 
 void InlineStylePropertyMap::remove(CSSPropertyID propertyID, ExceptionState& exceptionState)
 {
     ASSERT(propertyID != CSSPropertyInvalid);
     m_ownerElement->removeInlineStyleProperty(propertyID);
 }
 
 } // namespace blink