Implement ComputedStylePropertyMap for Typed OM.

third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

 // Copyright 2016 the chromium authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/StylePropertyMap.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/css/cssom/SimpleLength.h"
 #include "core/css/cssom/StyleValue.h"
+#include "core/css/cssom/StyleValueFactory.h"
 
 namespace blink {
 
 StyleValue* StylePropertyMap::get(const String& propertyName, ExceptionState& exceptionState)
 {
     CSSPropertyID propertyID = cssPropertyID(propertyName);
-    if (propertyID != CSSPropertyInvalid)
-        return get(propertyID);
+    if (propertyID == CSSPropertyInvalid) {
+        // TODO(meade): Handle custom properties here.
+        exceptionState.throwTypeError("Invalid propertyName: " + propertyName);
+        return nullptr;
+    }
 
-    // TODO(meade): Handle custom properties here.
-    exceptionState.throwTypeError("Invalid propertyName: " + propertyName);
-    return nullptr;
+    StyleValueVector styleVector = getAll(propertyID);
+    if (styleVector.isEmpty())
+        return nullptr;
+
+    return styleVector.at(0);
 }
 
-HeapVector<Member<StyleValue>> StylePropertyMap::getAll(const String& propertyName, ExceptionState& exceptionState)
+StylePropertyMap::StyleValueVector StylePropertyMap::getAll(const String& propertyName, ExceptionState& exceptionState)
 {
     CSSPropertyID propertyID = cssPropertyID(propertyName);
     if (propertyID != CSSPropertyInvalid)
         return getAll(propertyID);
 
     // TODO(meade): Handle custom properties here.
     exceptionState.throwTypeError("Invalid propertyName: " + propertyName);
     return HeapVector<Member<StyleValue>>();
 }
 
@@ skipping 34 matching lines @@
 {
     CSSPropertyID propertyID = cssPropertyID(propertyName);
     if (propertyID != CSSPropertyInvalid) {
         remove(propertyID, exceptionState);
         return;
     }
     // TODO(meade): Handle custom properties here.
     exceptionState.throwTypeError("Invalid propertyName: " + propertyName);
 }
 
+StylePropertyMap::StyleValueVector StylePropertyMap::cssValueToStyleValueVector(CSSPropertyID propertyID, const CSSValue& cssValue)

[Timothy Loh, 2016/04/15 04:16:08]

The part of the CL which just moves code around should be a separate CL, since
it doesn't need the rest of the change to go along with it. Smaller CLs are
easier/quicker to review than larger CLs.

+{
+    StyleValueVector styleValueVector;
+
+    if (!cssValue.isValueList()) {
+        StyleValue* styleValue = StyleValueFactory::create(propertyID, cssValue);
+        if (styleValue)
+            styleValueVector.append(styleValue);
+        return styleValueVector;
+    }
+
+    for (const Member<CSSValue> value : *toCSSValueList(&cssValue)) {

[Timothy Loh, 2016/04/15 04:16:08]

Wasn't this CSSValue* previously?

+        StyleValue* styleValue = StyleValueFactory::create(propertyID, *value);
+        if (!styleValue)
+            return StyleValueVector();
+        styleValueVector.append(styleValue);
+    }
+
+    return styleValueVector;
+}
+
 } // namespace blink