Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 1849643002: Add support for async, metadata, and counter timeline events to be reported by the embedder (Closed)

Created:
4 years, 8 months ago by Cutch
Modified:
4 years, 8 months ago
Reviewers:
rmacnak, Chinmay
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for async, metadata, and counter timeline events to be reported by the embedder Fixes #26142 R=chinmaygarde@google.com Committed: https://github.com/dart-lang/sdk/commit/d8df41c4835705834badf06ddeef1eee644b6312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -7 lines) Patch
M runtime/include/dart_tools_api.h View 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 8 months ago (2016-03-30 23:33:28 UTC) #3
Chinmay
lgtm
4 years, 8 months ago (2016-03-30 23:37:40 UTC) #4
Cutch
Committed patchset #1 (id:1) manually as d8df41c4835705834badf06ddeef1eee644b6312 (presubmit successful).
4 years, 8 months ago (2016-03-30 23:45:54 UTC) #6
rmacnak
4 years, 8 months ago (2016-03-31 00:02:19 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698