recipe_engine/package.py - Issue 1849563004: Fix: Use -C instead of --git-dir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_engine/package.py

Issue 1849563004: Fix: Use -C instead of --git-dir. (Closed) Base URL: https://github.com/luci/recipes-py@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: recipe_engine/package.py

diff --git a/recipe_engine/package.py b/recipe_engine/package.py

index 1c0e63fe7cfe0ead8c6f9dc43ddd9f5568204ff0..37b0a5a6fa0fd3f3ae9f37c889ed58db6cfc3187 100644

--- a/recipe_engine/package.py

+++ b/recipe_engine/package.py

@@ -199,7 +199,7 @@ class GitRepoSpec(RepoSpec):

def run_git(self, context, *args):

cmd = [self._git]

if context is not None:

- cmd += ['--git-dir', os.path.join(self._dep_dir(context), '.git')]

+ cmd += ['-C', self._dep_dir(context)]

cmd += list(args)

logging.info('Running: %s', cmd)

« no previous file with comments | « no previous file | unittests/package_test.py » ('j') | no next file with comments »