Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1849563002: Re-order the BookmarkBarView to be behind the ToolbarView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/animation/ink_drop_host_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index f0e4383ae15bd76c454c0d9a496ffc9c697c0f0d..694a5ef3a82c3ef2c1133204bb91282074a56b83 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2218,17 +2218,24 @@ void BrowserView::SetBookmarkBarParent(views::View* new_parent) {
// Add it underneath |top_container_| or at the end if top container isn't
// found.
int top_container_index = GetIndexOf(top_container_);
+ LOG(ERROR) << " *** Adding |bookmark_bar_view_| to '" << new_parent->GetClassName() << "' top_container_index=" << top_container_index;
if (top_container_index >= 0)
AddChildViewAt(bookmark_bar_view_.get(), top_container_index);
else
AddChildView(bookmark_bar_view_.get());
} else if (new_parent) {
// No special stacking is required for other parents.
+ LOG(ERROR) << " *** Adding |bookmark_bar_view_| to '" << new_parent->GetClassName() << "'";
new_parent->AddChildView(bookmark_bar_view_.get());
+ // new_parent->AddChildViewAt(bookmark_bar_view_.get(), 0);
bruthig 2016/03/30 19:52:43 This is the actual desired change here.
} else {
// Bookmark bar is being detached from all views because it is hidden.
+ LOG(ERROR) << " *** Removing |bookmark_bar_view_| from '" << bookmark_bar_view_->parent()->GetClassName() << "'";
bookmark_bar_view_->parent()->RemoveChildView(bookmark_bar_view_.get());
}
+#if !defined(NDEBUG)
+ LOG(ERROR) << " *** " << PrintViewGraph(true);
+#endif
}
bool BrowserView::MaybeShowInfoBar(WebContents* contents) {
« no previous file with comments | « no previous file | ui/views/animation/ink_drop_host_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698