MD Settings: validate startup URLs

chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js

Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
index 3f9da830ac5b77fae550d1b766873610aba05f3b..88e06c5edf67322192f334e15e4556e73aa88cdb 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
@@ -11,8 +11,11 @@ cr.define('settings', function() {
 
     useCurrentPages: assertNotReached,
 
-    /** @param {string} url */
-    canAddPage: assertNotReached,
+    /**
+     * @param {string} url
+     * @return {Promise<boolean>} Whether the URL is valid.

[dpapad, 2016/03/31 18:39:56]

!Promise<boolean>

[Dan Beam, 2016/03/31 22:06:55]

Done.

+     */
+    validateStartupPage: assertNotReached,
 
     /** @param {string} url */
     addStartupPage: assertNotReached,
@@ -30,23 +33,30 @@ cr.define('settings', function() {
   cr.addSingletonGetter(StartupUrlsPageBrowserProxyImpl);
 
   StartupUrlsPageBrowserProxyImpl.prototype = {
+    /** @override */
     loadStartupPages: function() {
       chrome.send('onStartupPrefsPageLoad');
     },
 
+    /** @override */
     useCurrentPages: function() {
       chrome.send('setStartupPagesToCurrentPages');
     },
 
-    canAddPage: function(url) {
-      // TODO(dbeam): hook up to C++ for deeper validation.
-      return url.trim().length > 0;
+    /** @override */
+    validateStartupPage: function(url) {
+      if (url.trim().length == 0)

[dpapad, 2016/03/31 18:39:56]

Nit (optional):

return url.trim().length == 0 ?
    Promise.resolve(false) :
    cr.sendWithPromise('validateStartupPage', url);

[Dan Beam, 2016/03/31 22:06:55]

Done. (but not clearer, imo, and doesn't shave lines)

+        return Promise.resolve(false);
+
+      return cr.sendWithPromise('validateStartupPage', url);
     },
 
+    /** @override */
     addStartupPage: function(url) {
       chrome.send('addStartupPage', [url.trim()]);
     },
 
+    /** @override */
     removeStartupPage: function(index) {
       chrome.send('removeStartupPage', [index]);
     },