chrome/browser/resources/settings/on_startup_page/startup_urls_page.html - Issue 1849543006: MD Settings: validate startup URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

Issue 1849543006: MD Settings: validate startup URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup-browser-proxy

Patch Set: compile fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/on_startup_page/startup_urls_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

index 07b7c1104507f49717aee83283d36a314aac6abc..6819ca7d9e05f4daecc57daaae3da841b2f4496e 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

@@ -30,7 +30,7 @@

<iron-icon on-tap="onRemoveUrlTap_" icon="clear"></iron-icon>

</div>

</template>

- <div class="list-item list-button" on-tap="onAddPageTap_"

+ <div class="list-item list-button" id="addPage" on-tap="onAddPageTap_"

i18n-content="onStartupAddNewPage">

</div>

<div class="list-item list-button" on-tap="onUseCurrentPagesTap_"

@@ -41,7 +41,7 @@

<settings-dialog id="addUrlDialog">

- <paper-input class="flex" always-float-label

+ <paper-input class="flex" always-float-label id="newUrl"

i18n-values="label:onStartupSiteUrl" value="{{newUrl_}}">

</paper-input>

</div>

@@ -49,8 +49,8 @@

<paper-button class="cancel-button" on-tap="onCancelTap_"

id="cancel" i18n-content="cancel"></paper-button>

- <paper-button class="action-button" on-tap="onAddTap_"

- i18n-content="add" disabled="[[!isAddEnabled_(newUrl_)]]">

+ <paper-button id="add" class="action-button" on-tap="onAddTap_"

+ i18n-content="add" disabled="[[!isNewUrlValid_]]">

</paper-button>

</div>