S390: [wasm] Int64Lowering of Int64Mul on ia32 and arm.

S390: [wasm] Int64Lowering of Int64Mul.

port 40bdbef975779e41a7e81d3748342dd7da52977f

 Original commit message:
     Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new
     operator takes 4 inputs an generates 2 outputs. The inputs are the low
     word of the left input, high word of the left input, the low word of the
     right input, and high word of the right input. The ouputs are the low
     and high word of the result of the multiplication.

R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=

Committed: https://crrev.com/b295462e8440855ab5190d561016204601de6e43
Cr-Commit-Position: refs/heads/master@{#35167}

[john.yan, 2016-03-30 20:56:19]

PTAL

[john.yan, 2016-03-30 21:01:44]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 21:01:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849543003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849543003/1

[JoranSiu, 2016-03-30 21:23:19]

https://codereview.chromium.org/1849543003/diff/1/src/compiler/s390/code-gene...
File src/compiler/s390/code-generator-s390.cc (right):

https://codereview.chromium.org/1849543003/diff/1/src/compiler/s390/code-gene...
src/compiler/s390/code-generator-s390.cc:885: case kS390_MulPair:
Why don't we load the full 64-bit value in R0 and R1, and use a 64-bit MSGR
instead?   It'll be more efficient.  We are able to use 64-bit instructions on
32-bit.

[commit-bot: I haz the power, 2016-03-30 21:24:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 21:24:27]

Dry run: This issue passed the CQ dry run.

[john.yan, 2016-03-31 03:50:36]

https://codereview.chromium.org/1849543003/diff/1/src/compiler/s390/code-gene...
File src/compiler/s390/code-generator-s390.cc (right):

https://codereview.chromium.org/1849543003/diff/1/src/compiler/s390/code-gene...
src/compiler/s390/code-generator-s390.cc:885: case kS390_MulPair:
On 2016/03/30 21:23:19, JoranSiu wrote:
> Why don't we load the full 64-bit value in R0 and R1, and use a 64-bit MSGR
> instead?   It'll be more efficient.  We are able to use 64-bit instructions on
> 32-bit.

OK.

[titzer, 2016-03-31 08:50:24]

Description was changed from

==========
S390: [wasm] Int64Lowering of Int64Mul on ia32 and arm.

port 40bdbef975779e41a7e81d3748342dd7da52977f

 Original commit message:
     Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new
     operator takes 4 inputs an generates 2 outputs. The inputs are the low
     word of the left input, high word of the left input, the low word of the
     right input, and high word of the right input. The ouputs are the low
     and high word of the result of the multiplication.

R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com
BUG=
==========

to

==========
S390: [wasm] Int64Lowering of Int64Mul.

port 40bdbef975779e41a7e81d3748342dd7da52977f

 Original commit message:
     Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new
     operator takes 4 inputs an generates 2 outputs. The inputs are the low
     word of the left input, high word of the left input, the low word of the
     right input, and high word of the right input. The ouputs are the low
     and high word of the result of the multiplication.

R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com
BUG=
==========

[john.yan, 2016-03-31 13:51:13]

On 2016/03/30 21:23:19, JoranSiu wrote:
>
https://codereview.chromium.org/1849543003/diff/1/src/compiler/s390/code-gene...
> File src/compiler/s390/code-generator-s390.cc (right):
> 
>
https://codereview.chromium.org/1849543003/diff/1/src/compiler/s390/code-gene...
> src/compiler/s390/code-generator-s390.cc:885: case kS390_MulPair:
> Why don't we load the full 64-bit value in R0 and R1, and use a 64-bit MSGR
> instead?   It'll be more efficient.  We are able to use 64-bit instructions on
> 32-bit.

Updated.

[JoranSiu, 2016-03-31 13:54:12]

On 2016/03/31 13:51:13, john.yan wrote:
> On 2016/03/30 21:23:19, JoranSiu wrote:
> >
>
https://codereview.chromium.org/1849543003/diff/1/src/compiler/s390/code-gene...
> > File src/compiler/s390/code-generator-s390.cc (right):
> > 
> >
>
https://codereview.chromium.org/1849543003/diff/1/src/compiler/s390/code-gene...
> > src/compiler/s390/code-generator-s390.cc:885: case kS390_MulPair:
> > Why don't we load the full 64-bit value in R0 and R1, and use a 64-bit MSGR
> > instead?   It'll be more efficient.  We are able to use 64-bit instructions
on
> > 32-bit.
> 
> Updated.

lgtm

[john.yan, 2016-03-31 13:58:44]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2016-03-31 13:58:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849543003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849543003/20001

[commit-bot: I haz the power, 2016-03-31 14:23:48]

Description was changed from

==========
S390: [wasm] Int64Lowering of Int64Mul.

port 40bdbef975779e41a7e81d3748342dd7da52977f

 Original commit message:
     Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new
     operator takes 4 inputs an generates 2 outputs. The inputs are the low
     word of the left input, high word of the left input, the low word of the
     right input, and high word of the right input. The ouputs are the low
     and high word of the result of the multiplication.

R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com
BUG=
==========

to

==========
S390: [wasm] Int64Lowering of Int64Mul.

port 40bdbef975779e41a7e81d3748342dd7da52977f

 Original commit message:
     Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new
     operator takes 4 inputs an generates 2 outputs. The inputs are the low
     word of the left input, high word of the left input, the low word of the
     right input, and high word of the right input. The ouputs are the low
     and high word of the result of the multiplication.

R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com
BUG=
==========

[commit-bot: I haz the power, 2016-03-31 14:23:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 14:24:31]

Description was changed from

==========
S390: [wasm] Int64Lowering of Int64Mul.

port 40bdbef975779e41a7e81d3748342dd7da52977f

 Original commit message:
     Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new
     operator takes 4 inputs an generates 2 outputs. The inputs are the low
     word of the left input, high word of the left input, the low word of the
     right input, and high word of the right input. The ouputs are the low
     and high word of the result of the multiplication.

R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com
BUG=
==========

to

==========
S390: [wasm] Int64Lowering of Int64Mul.

port 40bdbef975779e41a7e81d3748342dd7da52977f

 Original commit message:
     Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new
     operator takes 4 inputs an generates 2 outputs. The inputs are the low
     word of the left input, high word of the left input, the low word of the
     right input, and high word of the right input. The ouputs are the low
     and high word of the result of the multiplication.

R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com
BUG=

Committed: https://crrev.com/b295462e8440855ab5190d561016204601de6e43
Cr-Commit-Position: refs/heads/master@{#35167}
==========

[commit-bot: I haz the power, 2016-03-31 14:24:31]

Patchset 2 (id:??) landed as
https://crrev.com/b295462e8440855ab5190d561016204601de6e43
Cr-Commit-Position: refs/heads/master@{#35167}