Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849533003: Revert of Ignore deprecated declaration warnings in GTM. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ignore deprecated declaration warnings in GTM. (patchset #1 id:1 of https://codereview.chromium.org/1752513002/ ) Reason for revert: Reverting patchset as requested by thakis@. """ I don't think that's the right fix. When moving from 10.5 to 10.6, we fixed the warnings in GTM. We should do this again. In general, adding -Wno-deprecated-declarations is almost never the right fix. """ Original issue's description: > Ignore deprecated declaration warnings in GTM. > > GTM supports ancient iOS and OSX versions, so it's full of APIs that have been > deprecated in more recent iOS and OSX versions. Ignore all deprecated > declaration warnings. > > BUG=547071 > > Committed: https://crrev.com/911d21a2392ead090e2c4bbe3fb3285546865d7b > Cr-Commit-Position: refs/heads/master@{#378539} TBR=mark@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=547071 Committed: https://crrev.com/400cf2fcc7edcb6c792cbfa5984beb4ef3b35e5b Cr-Commit-Position: refs/heads/master@{#384073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
erikchen
Created Revert of Ignore deprecated declaration warnings in GTM.
4 years, 8 months ago (2016-03-30 18:56:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849533003/1
4 years, 8 months ago (2016-03-30 18:57:07 UTC) #2
Nico
Thank you!
4 years, 8 months ago (2016-03-30 19:01:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849533003/1
4 years, 8 months ago (2016-03-30 19:01:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849533003/1
4 years, 8 months ago (2016-03-30 19:31:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849533003/1
4 years, 8 months ago (2016-03-30 20:01:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 20:15:34 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:17:44 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/400cf2fcc7edcb6c792cbfa5984beb4ef3b35e5b
Cr-Commit-Position: refs/heads/master@{#384073}

Powered by Google App Engine
This is Rietveld 408576698