Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2160)

Unified Diff: device/bluetooth/bluetooth_chromeos_unittest.cc

Issue 184953002: Migrate Chrome OS Bluetooth UI to the new discovery API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments by derat@ and keybuk@. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/bluetooth_adapter_chromeos.cc ('k') | device/bluetooth/bluetooth_discovery_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_chromeos_unittest.cc
diff --git a/device/bluetooth/bluetooth_chromeos_unittest.cc b/device/bluetooth/bluetooth_chromeos_unittest.cc
index 4b51bbed748c13cbdd87e3f1bd478f024ace2152..316d62979009fd846d02f45f227c0cd286649516 100644
--- a/device/bluetooth/bluetooth_chromeos_unittest.cc
+++ b/device/bluetooth/bluetooth_chromeos_unittest.cc
@@ -246,7 +246,7 @@ class BluetoothChromeOSTest : public testing::Test {
}
virtual void TearDown() {
- if (last_discovery_session_.get() && last_discovery_session_->active()) {
+ if (last_discovery_session_.get() && last_discovery_session_->IsActive()) {
callback_count_ = 0;
last_discovery_session_->Stop(
base::Bind(&BluetoothChromeOSTest::Callback,
@@ -1323,7 +1323,7 @@ TEST_F(BluetoothChromeOSTest, StartDiscoverySession) {
EXPECT_TRUE(observer.last_discovering_);
EXPECT_TRUE(adapter_->IsDiscovering());
EXPECT_TRUE(last_discovery_session_.get());
- EXPECT_TRUE(last_discovery_session_->active());
+ EXPECT_TRUE(last_discovery_session_->IsActive());
// Start another session. A new one should be returned in the callback, which
// in turn will destroy the previous session. Adapter should still be
@@ -1340,7 +1340,7 @@ TEST_F(BluetoothChromeOSTest, StartDiscoverySession) {
EXPECT_TRUE(observer.last_discovering_);
EXPECT_TRUE(adapter_->IsDiscovering());
EXPECT_TRUE(last_discovery_session_.get());
- EXPECT_TRUE(last_discovery_session_->active());
+ EXPECT_TRUE(last_discovery_session_->IsActive());
// Hold on to the current discovery session to prevent it from getting
// destroyed during the next call to StartDiscoverySession.
@@ -1360,7 +1360,7 @@ TEST_F(BluetoothChromeOSTest, StartDiscoverySession) {
EXPECT_TRUE(observer.last_discovering_);
EXPECT_TRUE(adapter_->IsDiscovering());
EXPECT_TRUE(last_discovery_session_.get());
- EXPECT_TRUE(last_discovery_session_->active());
+ EXPECT_TRUE(last_discovery_session_->IsActive());
EXPECT_NE(last_discovery_session_.get(), discovery_session);
// Stop the previous discovery session. The session should end but discovery
@@ -1377,8 +1377,8 @@ TEST_F(BluetoothChromeOSTest, StartDiscoverySession) {
EXPECT_TRUE(observer.last_discovering_);
EXPECT_TRUE(adapter_->IsDiscovering());
EXPECT_TRUE(last_discovery_session_.get());
- EXPECT_TRUE(last_discovery_session_->active());
- EXPECT_FALSE(discovery_session->active());
+ EXPECT_TRUE(last_discovery_session_->IsActive());
+ EXPECT_FALSE(discovery_session->IsActive());
// Delete the current active session. Discovery should eventually stop.
last_discovery_session_.reset();
« no previous file with comments | « device/bluetooth/bluetooth_adapter_chromeos.cc ('k') | device/bluetooth/bluetooth_discovery_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698