Migrate Chrome OS Bluetooth UI to the new discovery API.

chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var OptionsPage = options.OptionsPage;
 
   /**
    * Encapsulated handling of the Bluetooth options page.
    * @constructor
@@ skipping 16 matching lines @@
      * @private
      */
     deviceList_: null,
 
     /** @override */
     initializePage: function() {
       OptionsPage.prototype.initializePage.call(this);
       this.createDeviceList_();
 
       $('bluetooth-add-device-cancel-button').onclick = function(event) {
-        chrome.send('stopBluetoothDeviceDiscovery');
         OptionsPage.closeOverlay();
       };
 
       var self = this;
       $('bluetooth-add-device-apply-button').onclick = function(event) {
         var device = self.deviceList_.selectedItem;
         var address = device.address;
-        chrome.send('stopBluetoothDeviceDiscovery');
         OptionsPage.closeOverlay();

[keybuk, 2014/02/28 21:29:28]

While this looks like it closes the overlay, it immediately opens it again ...
so I'm not sure didClosePage would get called

We probably don't want the scan on while we're actually pairing, right?

[xiyuan, 2014/02/28 22:21:25]

This is probably okay. Pairing and this add device are two different overlays.
When OptionsPage.closeOverlay() is called, the current overlay's didClosePage is
called before returning.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

So even we show pairing overlay immediately after this, it is a different
overlay and does not affect the add-device overlay's didClosePage.

         device.pairing = 'bluetoothStartConnecting';
         options.BluetoothPairing.showDialog(device);
         chrome.send('updateBluetoothDevice', [address, 'connect']);
       };
 
       $('bluetooth-unpaired-devices-list').addEventListener('change',
                                                             function() {
         var item = $('bluetooth-unpaired-devices-list').selectedItem;
         // The "bluetooth-add-device-apply-button" should be enabled for devices
         // that can be paired or remembered. Devices not supporting pairing will
         // be just remembered and later reported as "item.paired" = true. The
         // button should be disabled in any other case:
         // * No item is selected (item is undefined).
         // * Paired devices (item.paired is true) are already paired and a new
         //   pairing attempt will fail. Paired devices could appear in this list
         //   shortly after the pairing initiated in another window finishes.
         // * "Connecting" devices (item.connecting is true) are in the process
         //   of a pairing or connection. Another attempt to pair before the
         //   ongoing pair finishes will fail, so the button should be disabled.
         var disabled = !item || item.paired || item.connecting;
         $('bluetooth-add-device-apply-button').disabled = disabled;
       });
     },
 
+    /** @override */
+    didClosePage: function() {
+      chrome.send('stopBluetoothDeviceDiscovery');
+    },
+
     /**
      * Creates, decorates and initializes the bluetooth device list.
      * @private
      */
     createDeviceList_: function() {
       this.deviceList_ = $('bluetooth-unpaired-devices-list');
       options.system.bluetooth.BluetoothDeviceList.decorate(this.deviceList_);
     }
   };
 
   /**
    * Automatically start the device discovery process if the
    * "Add device" dialog is visible.
    */
   BluetoothOptions.updateDiscovery = function() {
     var page = BluetoothOptions.getInstance();
     if (page && page.visible)
       chrome.send('findBluetoothDevices');
   }
 
   // Export
   return {
     BluetoothOptions: BluetoothOptions
   };
 });