Migrate Chrome OS Bluetooth UI to the new discovery API.

Migrate Chrome OS Bluetooth UI to the new discovery API.

This CL migrates BluetoothOptionsHandler and ash::SystemTrayDelegate to the
new discovery session API, removing calls to the now deprecated
device::BluetoothAdapter::Start|StopDiscovering.

BUG=346982
TEST=Tested that discovery logic works on Uber tray and chrome://settings. Opened
multiple tabs with chrome://settings/search#Bluetooth. Also tested that all
BluetoothDiscoverySession objects are marked as inactive when the adapter gets
powered down via bt_console.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254727

[armansito, 2014-02-28 20:59:59]

derat@: PTAL at chrome/browser/ui/ash/system_tray_delegate_chromeos.*
xiyuan@: PTAL at
chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js
keybuk@: PTAL at everything.

[Daniel Erat, 2014-02-28 21:22:36]

lgtm w/nits for system_tray_delegate_chromeos.*

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/ash/system...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.h (right):

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/ash/system...
chrome/browser/ui/ash/system_tray_delegate_chromeos.h:226: void
OnStartDiscoverySession(
nit: mind renaming this to something like OnStartBluetoothDiscoverySession? it
seems a bit vaguely-named otherwise

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/ash/system...
chrome/browser/ui/ash/system_tray_delegate_chromeos.h:256: bool
bluetooth_should_discover_;
nit: rename to something like "do_bluetooth_discovery_" or
"should_do_bluetooth_discovery_"

[keybuk, 2014-02-28 21:29:28]

https://codereview.chromium.org/184953002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js
(right):

https://codereview.chromium.org/184953002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js:44:
OptionsPage.closeOverlay();
While this looks like it closes the overlay, it immediately opens it again ...
so I'm not sure didClosePage would get called

We probably don't want the scan on while we're actually pairing, right?

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc
(right):

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc:244:
discovery_session_ = discovery_session.Pass();
Doesn't this need the same logic as Aura, what if the UI has closed the pairing
page before this is called?

[xiyuan, 2014-02-28 22:21:25]

webui LGTM

https://codereview.chromium.org/184953002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js
(right):

https://codereview.chromium.org/184953002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js:44:
OptionsPage.closeOverlay();
On 2014/02/28 21:29:28, keybuk wrote:
> While this looks like it closes the overlay, it immediately opens it again ...
> so I'm not sure didClosePage would get called
> 
> We probably don't want the scan on while we're actually pairing, right?

This is probably okay. Pairing and this add device are two different overlays.
When OptionsPage.closeOverlay() is called, the current overlay's didClosePage is
called before returning.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

So even we show pairing overlay immediately after this, it is a different
overlay and does not affect the add-device overlay's didClosePage.

[armansito, 2014-02-28 22:52:01]

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/ash/system...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.h (right):

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/ash/system...
chrome/browser/ui/ash/system_tray_delegate_chromeos.h:226: void
OnStartDiscoverySession(
On 2014/02/28 21:22:36, Daniel Erat wrote:
> nit: mind renaming this to something like OnStartBluetoothDiscoverySession? it
> seems a bit vaguely-named otherwise

Done.

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/ash/system...
chrome/browser/ui/ash/system_tray_delegate_chromeos.h:256: bool
bluetooth_should_discover_;
On 2014/02/28 21:22:36, Daniel Erat wrote:
> nit: rename to something like "do_bluetooth_discovery_" or
> "should_do_bluetooth_discovery_"

Done.

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc
(right):

https://codereview.chromium.org/184953002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc:244:
discovery_session_ = discovery_session.Pass();
On 2014/02/28 21:29:28, keybuk wrote:
> Doesn't this need the same logic as Aura, what if the UI has closed the
pairing
> page before this is called?

It certainly does. Done.

[keybuk, 2014-03-03 19:43:56]

lgtm

[armansito, 2014-03-03 22:20:06]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-03-03 22:20:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/184953002/20001

[commit-bot: I haz the power, 2014-03-04 01:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-04 01:12:41]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[armansito, 2014-03-04 01:17:09]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-03-04 01:19:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/184953002/20001

[commit-bot: I haz the power, 2014-03-04 04:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-04 04:22:06]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[armansito, 2014-03-04 06:15:24]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-03-04 06:15:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/184953002/20001

[commit-bot: I haz the power, 2014-03-04 08:30:38]

Change committed as 254727