Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1849503002: [crankshaft] [turbofan] Fix environment handling when generating a tail call from inlined function. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] [turbofan] Fix environment handling when generating a tail call from inlined function. This CL ensures that we build environments/frame states so that tail caller frame will never become topmost. BUG=chromium:598998, v8:4698 LOG=N Committed: https://crrev.com/ecb8fcfcca4c35a32a8c10bf63dd090bdc5424c4 Cr-Commit-Position: refs/heads/master@{#35188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -32 lines) Patch
M src/compiler/instruction-selector.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +5 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-598998.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Igor Sheludko
PTAL whoever is first back.
4 years, 8 months ago (2016-03-30 17:44:38 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849503002/1
4 years, 8 months ago (2016-03-30 17:44:48 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 18:07:11 UTC) #8
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-01 06:37:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849503002/1
4 years, 8 months ago (2016-04-01 06:42:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 07:22:27 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ecb8fcfcca4c35a32a8c10bf63dd090bdc5424c4 Cr-Commit-Position: refs/heads/master@{#35188}
4 years, 8 months ago (2016-04-01 07:22:54 UTC) #15
Michael Starzinger
4 years, 8 months ago (2016-04-01 08:53:13 UTC) #16
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698