Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1849453004:
SkPDF: Make magic make sense (Closed)
|
Created:
4 years, 8 months ago by hal.canary Modified:
4 years, 8 months ago Reviewers:
tomhudson CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSkPDF: Make magic make sense
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849453004
Committed: https://skia.googlesource.com/skia/+/ad5dcd17cd9996a99068601d11df1c27b3652b9a
Patch Set 1 #Patch Set 2 : 2016-03-30 (Wednesday) 16:17:14 EDT #Messages
Total messages: 17 (9 generated)
Description was changed from ========== SkPDF: Make magic make sense ========== to ========== SkPDF: Make magic make sense GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== SkPDF: Make magic make sense GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: Make magic make sense GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849453004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849453004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849453004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
halcanary@google.com changed reviewers: + tomhudson@google.com
ptal
The CQ bit was checked by tomhudson@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849453004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849453004/20001
Message was sent while issue was closed.
Description was changed from ========== SkPDF: Make magic make sense GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: Make magic make sense GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/ad5dcd17cd9996a99068601d11df1c27b3652b9a ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/ad5dcd17cd9996a99068601d11df1c27b3652b9a |
